Re: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-12 Thread Andrew Lunn
On Tue, Dec 11, 2018 at 11:59:34PM +, tristram...@microchip.com wrote: > > I'd be careful about locking. Seems like dsa was designed with "tag > > format is static", and you want to change it dynamically... > > I see there is now a new overhead parameter in the dsa_device_ops structure > and d

RE: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-11 Thread Tristram.Ha
> I'd be careful about locking. Seems like dsa was designed with "tag > format is static", and you want to change it dynamically... I see there is now a new overhead parameter in the dsa_device_ops structure and dev_set_mtu is called in master.c. It does not prevent the tag size to change dynamic

Re: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-09 Thread Pavel Machek
On Thu 2018-12-06 20:00:26, tristram...@microchip.com wrote: > > >>> Update tag_ksz.c to access switch driver's tail tagging operations. > > >> > > >> Hi Tristram > > >> > > >> Humm, i'm not sure we want this, the tagging spit into two places. I > > >> need to take a closer look at the previous pa

Re: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-06 Thread Richard Cochran
On Thu, Dec 06, 2018 at 08:00:26PM +, tristram...@microchip.com wrote: > A customer has already inquired about implementing 1588 PTP in the DSA > driver. I hope > this mechanism is approved so that I can start doing that. If you need changes to the PTP core, you had better discuss this with

Re: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-06 Thread Andrew Lunn
> I did try to implement this way. But the other switches do not have the same > format even though the length is the same. Then I need to change the > following > files for any new KSZ switch: include/linux/dsa.h, net/dsa/dsa.c, > net/dsa/dsa_priv.h, > and finally net/dsa/tag_ksz.c. You can a

RE: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-06 Thread Tristram.Ha
> >>> Update tag_ksz.c to access switch driver's tail tagging operations. > >> > >> Hi Tristram > >> > >> Humm, i'm not sure we want this, the tagging spit into two places. I > >> need to take a closer look at the previous patch, to see why it cannot > >> be done here. > > > > O.K, i think i get w

Re: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-05 Thread Florian Fainelli
On 12/5/18 10:18 AM, Andrew Lunn wrote: > On Wed, Dec 05, 2018 at 07:00:38PM +0100, Andrew Lunn wrote: >> On Mon, Dec 03, 2018 at 03:34:56PM -0800, tristram...@microchip.com wrote: >>> From: Tristram Ha >>> >>> Update tag_ksz.c to access switch driver's tail tagging operations. >> >> Hi Tristram >

Re: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-05 Thread Andrew Lunn
On Wed, Dec 05, 2018 at 07:00:38PM +0100, Andrew Lunn wrote: > On Mon, Dec 03, 2018 at 03:34:56PM -0800, tristram...@microchip.com wrote: > > From: Tristram Ha > > > > Update tag_ksz.c to access switch driver's tail tagging operations. > > Hi Tristram > > Humm, i'm not sure we want this, the ta

Re: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-05 Thread Andrew Lunn
On Mon, Dec 03, 2018 at 03:34:56PM -0800, tristram...@microchip.com wrote: > From: Tristram Ha > > Update tag_ksz.c to access switch driver's tail tagging operations. Hi Tristram Humm, i'm not sure we want this, the tagging spit into two places. I need to take a closer look at the previous pat

[PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-03 Thread Tristram.Ha
From: Tristram Ha Update tag_ksz.c to access switch driver's tail tagging operations. Signed-off-by: Tristram Ha --- net/dsa/tag_ksz.c | 44 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c index