Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver

2019-06-14 Thread Russell King - ARM Linux admin
On Fri, Jun 14, 2019 at 04:54:56PM +, Ioana Ciornei wrote: > > Subject: Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver > > > > On Fri, Jun 14, 2019 at 03:42:23AM +0200, Andrew Lunn wrote: > > > > +static phy_interface_t phy_mode(enum dpmac_eth_if eth_if) {

RE: [PATCH RFC 4/6] dpaa2-mac: add initial driver

2019-06-14 Thread Ioana Ciornei
> Subject: Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver > > On Fri, Jun 14, 2019 at 03:42:23AM +0200, Andrew Lunn wrote: > > > +static phy_interface_t phy_mode(enum dpmac_eth_if eth_if) { > > > + switch (eth_if) { > > > + case DPMAC_

RE: [PATCH RFC 4/6] dpaa2-mac: add initial driver

2019-06-14 Thread Ioana Ciornei
> Subject: Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver > > On Fri, Jun 14, 2019 at 02:55:51AM +0300, Ioana Ciornei wrote: > > The dpaa2-mac driver binds to DPAA2 DPMAC objects, dynamically > > discovered on the fsl-mc bus. It acts as a proxy between the PHY > >

RE: [PATCH RFC 4/6] dpaa2-mac: add initial driver

2019-06-14 Thread Ioana Ciornei
> Subject: Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver > > > +static phy_interface_t phy_mode(enum dpmac_eth_if eth_if) { > > + switch (eth_if) { > > + case DPMAC_ETH_IF_RGMII: > > + return PHY_INTERFACE_MODE_RGMII; > > So the MAC cann

Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver

2019-06-14 Thread Russell King - ARM Linux admin
On Fri, Jun 14, 2019 at 02:55:51AM +0300, Ioana Ciornei wrote: > The dpaa2-mac driver binds to DPAA2 DPMAC objects, dynamically > discovered on the fsl-mc bus. It acts as a proxy between the PHY > management layer and the MC firmware, delivering any configuration > changes to the firmware and also

Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver

2019-06-14 Thread Russell King - ARM Linux admin
On Fri, Jun 14, 2019 at 03:42:23AM +0200, Andrew Lunn wrote: > > +static phy_interface_t phy_mode(enum dpmac_eth_if eth_if) > > +{ > > + switch (eth_if) { > > + case DPMAC_ETH_IF_RGMII: > > + return PHY_INTERFACE_MODE_RGMII; > > So the MAC cannot insert RGMII delays? I didn't see any

Re: [PATCH RFC 4/6] dpaa2-mac: add initial driver

2019-06-13 Thread Andrew Lunn
> +static phy_interface_t phy_mode(enum dpmac_eth_if eth_if) > +{ > + switch (eth_if) { > + case DPMAC_ETH_IF_RGMII: > + return PHY_INTERFACE_MODE_RGMII; So the MAC cannot insert RGMII delays? I didn't see anything in the PHY object about configuring the delays. Does the PCB ne

[PATCH RFC 4/6] dpaa2-mac: add initial driver

2019-06-13 Thread Ioana Ciornei
The dpaa2-mac driver binds to DPAA2 DPMAC objects, dynamically discovered on the fsl-mc bus. It acts as a proxy between the PHY management layer and the MC firmware, delivering any configuration changes to the firmware and also setting any new configuration requested though PHYLINK. A in-depth vie