Re: [PATCH RFC 3/5] net: Add a netdev software feature set that defaults to off.

2019-10-02 Thread Willem de Bruijn
On Wed, Oct 2, 2019 at 4:27 AM Steffen Klassert wrote: > > On Tue, Oct 01, 2019 at 08:43:05AM -0400, Willem de Bruijn wrote: > > On Tue, Oct 1, 2019 at 2:18 AM Steffen Klassert > > wrote: > > > > > > On Mon, Sep 30, 2019 at 11:26:55AM -0400, Willem de Bruijn wrote: > > > > > > > > Instead, how ab

Re: [PATCH RFC 3/5] net: Add a netdev software feature set that defaults to off.

2019-10-02 Thread Steffen Klassert
On Tue, Oct 01, 2019 at 08:43:05AM -0400, Willem de Bruijn wrote: > On Tue, Oct 1, 2019 at 2:18 AM Steffen Klassert > wrote: > > > > On Mon, Sep 30, 2019 at 11:26:55AM -0400, Willem de Bruijn wrote: > > > > > > Instead, how about adding a UDP GRO ethtool feature independent of > > > forwarding, an

Re: [PATCH RFC 3/5] net: Add a netdev software feature set that defaults to off.

2019-10-01 Thread Willem de Bruijn
On Tue, Oct 1, 2019 at 2:18 AM Steffen Klassert wrote: > > On Mon, Sep 30, 2019 at 11:26:55AM -0400, Willem de Bruijn wrote: > > On Mon, Sep 30, 2019 at 2:24 AM Steffen Klassert > > wrote: > > > > > > On Mon, Sep 23, 2019 at 08:38:56AM -0400, Willem de Bruijn wrote: > > > > > > > > The UDP GRO be

Re: [PATCH RFC 3/5] net: Add a netdev software feature set that defaults to off.

2019-09-30 Thread Steffen Klassert
On Mon, Sep 30, 2019 at 11:26:55AM -0400, Willem de Bruijn wrote: > On Mon, Sep 30, 2019 at 2:24 AM Steffen Klassert > wrote: > > > > On Mon, Sep 23, 2019 at 08:38:56AM -0400, Willem de Bruijn wrote: > > > > > > The UDP GRO benchmarks were largely positive, but not a strict win if > > > I read Pao

Re: [PATCH RFC 3/5] net: Add a netdev software feature set that defaults to off.

2019-09-30 Thread Willem de Bruijn
On Mon, Sep 30, 2019 at 2:24 AM Steffen Klassert wrote: > > On Mon, Sep 23, 2019 at 08:38:56AM -0400, Willem de Bruijn wrote: > > On Fri, Sep 20, 2019 at 12:49 AM Steffen Klassert > > wrote: > > > > > > diff --git a/include/linux/netdev_features.h > > > b/include/linux/netdev_features.h > > > in

Re: [PATCH RFC 3/5] net: Add a netdev software feature set that defaults to off.

2019-09-29 Thread Steffen Klassert
On Mon, Sep 23, 2019 at 08:38:56AM -0400, Willem de Bruijn wrote: > On Fri, Sep 20, 2019 at 12:49 AM Steffen Klassert > wrote: > > > > diff --git a/include/linux/netdev_features.h > > b/include/linux/netdev_features.h > > index b239507da2a0..34d050bb1ae6 100644 > > --- a/include/linux/netdev_feat

Re: [PATCH RFC 3/5] net: Add a netdev software feature set that defaults to off.

2019-09-23 Thread Willem de Bruijn
On Fri, Sep 20, 2019 at 12:49 AM Steffen Klassert wrote: > > The previous patch added the NETIF_F_GRO_FRAGLIST feature. > This is a software feature that should default to off. > Current software features default to on, so add a new > feature set that defaults to off. > > Signed-off-by: Steffen Kl

[PATCH RFC 3/5] net: Add a netdev software feature set that defaults to off.

2019-09-19 Thread Steffen Klassert
The previous patch added the NETIF_F_GRO_FRAGLIST feature. This is a software feature that should default to off. Current software features default to on, so add a new feature set that defaults to off. Signed-off-by: Steffen Klassert --- include/linux/netdev_features.h | 3 +++ net/core/dev.c