Re: [PATCH RFC 3/3] net: convert tc_u32 to use the intermediate representation

2016-02-26 Thread David Miller
From: Pablo Neira Ayuso Date: Fri, 26 Feb 2016 17:02:22 +0100 > Just because you want to early microoptimize this thing by saving a > little of extra code that runs from the control plane path. I don't think that's what he is doing at all. We have classes of classifier etc. offloads that need I

Re: [PATCH RFC 3/3] net: convert tc_u32 to use the intermediate representation

2016-02-26 Thread David Miller
From: John Fastabend Date: Fri, 26 Feb 2016 06:53:11 -0800 > sure but its easier for me to just consume u32 at the moment. And I > am concerned about performance overhead with this IR. I'm going to need > to have a performant solution eventually and I don't like converting > into one IR only to g

Re: [PATCH RFC 3/3] net: convert tc_u32 to use the intermediate representation

2016-02-26 Thread John Fastabend
On 16-02-26 08:02 AM, Pablo Neira Ayuso wrote: > On Fri, Feb 26, 2016 at 06:53:11AM -0800, John Fastabend wrote: >> On 16-02-26 06:24 AM, Pablo Neira Ayuso wrote: >>> On Thu, Feb 25, 2016 at 12:37:38PM -0800, John Fastabend wrote: On 16-02-25 09:37 AM, Pablo Neira Ayuso wrote: > This patch

Re: [PATCH RFC 3/3] net: convert tc_u32 to use the intermediate representation

2016-02-26 Thread Pablo Neira Ayuso
On Fri, Feb 26, 2016 at 06:53:11AM -0800, John Fastabend wrote: > On 16-02-26 06:24 AM, Pablo Neira Ayuso wrote: > > On Thu, Feb 25, 2016 at 12:37:38PM -0800, John Fastabend wrote: > >> On 16-02-25 09:37 AM, Pablo Neira Ayuso wrote: > >>> This patch moves the u32 parser from the ixgbe that John has

Re: [PATCH RFC 3/3] net: convert tc_u32 to use the intermediate representation

2016-02-26 Thread John Fastabend
On 16-02-26 06:24 AM, Pablo Neira Ayuso wrote: > On Thu, Feb 25, 2016 at 12:37:38PM -0800, John Fastabend wrote: >> On 16-02-25 09:37 AM, Pablo Neira Ayuso wrote: >>> This patch moves the u32 parser from the ixgbe that John has made to the >>> core u32. This parser has been adapted to build the int

Re: [PATCH RFC 3/3] net: convert tc_u32 to use the intermediate representation

2016-02-26 Thread Pablo Neira Ayuso
On Thu, Feb 25, 2016 at 12:37:38PM -0800, John Fastabend wrote: > On 16-02-25 09:37 AM, Pablo Neira Ayuso wrote: > > This patch moves the u32 parser from the ixgbe that John has made to the > > core u32. This parser has been adapted to build the intermediate > > representation. > > > > To store th

Re: [PATCH RFC 3/3] net: convert tc_u32 to use the intermediate representation

2016-02-25 Thread John Fastabend
On 16-02-25 09:37 AM, Pablo Neira Ayuso wrote: > This patch moves the u32 parser from the ixgbe that John has made to the > core u32. This parser has been adapted to build the intermediate > representation. > > To store the parsing information, this patch introduces a parse table > object, one per

[PATCH RFC 3/3] net: convert tc_u32 to use the intermediate representation

2016-02-25 Thread Pablo Neira Ayuso
This patch moves the u32 parser from the ixgbe that John has made to the core u32. This parser has been adapted to build the intermediate representation. To store the parsing information, this patch introduces a parse table object, one per device, so we don't need to store the parsing states in th