Re: [PATCH RFC 2/4] net: sched: fix err handler in tcf_action_init()

2021-04-06 Thread Vlad Buslov
On Tue 06 Apr 2021 at 01:56, Cong Wang wrote: > On Sat, Apr 3, 2021 at 3:01 AM Vlad Buslov wrote: >> So, the following happens in reproduction provided in commit message >> when executing "tc actions add action simple sdata \"1\" index 1 >> action simple sdata \"2\" index 2" command: >> >> 1. t

Re: [PATCH RFC 2/4] net: sched: fix err handler in tcf_action_init()

2021-04-05 Thread Cong Wang
On Sat, Apr 3, 2021 at 3:01 AM Vlad Buslov wrote: > So, the following happens in reproduction provided in commit message > when executing "tc actions add action simple sdata \"1\" index 1 > action simple sdata \"2\" index 2" command: > > 1. tcf_action_init() is called with batch of two actions of

Re: [PATCH RFC 2/4] net: sched: fix err handler in tcf_action_init()

2021-04-03 Thread Vlad Buslov
On Sat 03 Apr 2021 at 02:14, Cong Wang wrote: > On Wed, Mar 31, 2021 at 9:41 AM Vlad Buslov wrote: >> >> With recent changes that separated action module load from action >> initialization tcf_action_init() function error handling code was modified >> to manually release the loaded modules if l

Re: [PATCH RFC 2/4] net: sched: fix err handler in tcf_action_init()

2021-04-02 Thread Cong Wang
On Wed, Mar 31, 2021 at 9:41 AM Vlad Buslov wrote: > > With recent changes that separated action module load from action > initialization tcf_action_init() function error handling code was modified > to manually release the loaded modules if loading/initialization of any > further action in same b

[PATCH RFC 2/4] net: sched: fix err handler in tcf_action_init()

2021-03-31 Thread Vlad Buslov
With recent changes that separated action module load from action initialization tcf_action_init() function error handling code was modified to manually release the loaded modules if loading/initialization of any further action in same batch failed. For the case when all modules successfully loaded