Re: [PATCH RFC 2/2] tun: don't set a default qdisc

2016-04-14 Thread Hannes Frederic Sowa
On 14.04.2016 12:01, Michael S. Tsirkin wrote: On Thu, Apr 14, 2016 at 05:21:40PM +0800, Jason Wang wrote: On 04/14/2016 05:10 PM, Michael S. Tsirkin wrote: On Thu, Apr 14, 2016 at 05:07:50PM +0800, Jason Wang wrote: On 04/14/2016 05:05 PM, Michael S. Tsirkin wrote: On Thu, Apr 14, 2016 at

Re: [PATCH RFC 2/2] tun: don't set a default qdisc

2016-04-14 Thread Michael S. Tsirkin
On Thu, Apr 14, 2016 at 05:21:40PM +0800, Jason Wang wrote: > > > On 04/14/2016 05:10 PM, Michael S. Tsirkin wrote: > > On Thu, Apr 14, 2016 at 05:07:50PM +0800, Jason Wang wrote: > >> > >> On 04/14/2016 05:05 PM, Michael S. Tsirkin wrote: > >>> On Thu, Apr 14, 2016 at 02:49:28PM +0800, Jason Wan

Re: [PATCH RFC 2/2] tun: don't set a default qdisc

2016-04-14 Thread Jason Wang
On 04/14/2016 05:10 PM, Michael S. Tsirkin wrote: > On Thu, Apr 14, 2016 at 05:07:50PM +0800, Jason Wang wrote: >> >> On 04/14/2016 05:05 PM, Michael S. Tsirkin wrote: >>> On Thu, Apr 14, 2016 at 02:49:28PM +0800, Jason Wang wrote: > > On 04/13/2016 06:26 PM, Michael S. Tsirkin wrote: >>>

Re: [PATCH RFC 2/2] tun: don't set a default qdisc

2016-04-14 Thread Michael S. Tsirkin
On Thu, Apr 14, 2016 at 05:07:50PM +0800, Jason Wang wrote: > > > On 04/14/2016 05:05 PM, Michael S. Tsirkin wrote: > > On Thu, Apr 14, 2016 at 02:49:28PM +0800, Jason Wang wrote: > >> > > >> > > >> > On 04/13/2016 06:26 PM, Michael S. Tsirkin wrote: > >>> > > On Wed, Apr 13, 2016 at 11:04:47AM

Re: [PATCH RFC 2/2] tun: don't set a default qdisc

2016-04-14 Thread Jason Wang
On 04/14/2016 05:05 PM, Michael S. Tsirkin wrote: > On Thu, Apr 14, 2016 at 02:49:28PM +0800, Jason Wang wrote: >> > >> > >> > On 04/13/2016 06:26 PM, Michael S. Tsirkin wrote: >>> > > On Wed, Apr 13, 2016 at 11:04:47AM +0200, Paolo Abeni wrote: > >> This patch disables the default qdisc b

Re: [PATCH RFC 2/2] tun: don't set a default qdisc

2016-04-14 Thread Michael S. Tsirkin
On Thu, Apr 14, 2016 at 02:49:28PM +0800, Jason Wang wrote: > > > On 04/13/2016 06:26 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 13, 2016 at 11:04:47AM +0200, Paolo Abeni wrote: > >> This patch disables the default qdisc by explicitly setting the > >> IFF_NO_QUEUE private flag so that now the

Re: [PATCH RFC 2/2] tun: don't set a default qdisc

2016-04-13 Thread Jason Wang
On 04/13/2016 06:26 PM, Michael S. Tsirkin wrote: > On Wed, Apr 13, 2016 at 11:04:47AM +0200, Paolo Abeni wrote: >> This patch disables the default qdisc by explicitly setting the >> IFF_NO_QUEUE private flag so that now the tun xmit path do not >> require any lock by default. >> >> The default q

Re: [PATCH RFC 2/2] tun: don't set a default qdisc

2016-04-13 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 13 Apr 2016 13:26:51 +0300 > On Wed, Apr 13, 2016 at 11:04:47AM +0200, Paolo Abeni wrote: >> This patch disables the default qdisc by explicitly setting the >> IFF_NO_QUEUE private flag so that now the tun xmit path do not >> require any lock by default. >>

Re: [PATCH RFC 2/2] tun: don't set a default qdisc

2016-04-13 Thread Michael S. Tsirkin
On Wed, Apr 13, 2016 at 11:04:47AM +0200, Paolo Abeni wrote: > This patch disables the default qdisc by explicitly setting the > IFF_NO_QUEUE private flag so that now the tun xmit path do not > require any lock by default. > > The default qdisc was first removed as a side effect of commit > f84bb1

[PATCH RFC 2/2] tun: don't set a default qdisc

2016-04-13 Thread Paolo Abeni
This patch disables the default qdisc by explicitly setting the IFF_NO_QUEUE private flag so that now the tun xmit path do not require any lock by default. The default qdisc was first removed as a side effect of commit f84bb1eac027 ("net: fix IFF_NO_QUEUE for drivers using alloc_netdev") and recen