Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-20 Thread Miguel Ojeda
On Sun, Jan 20, 2019 at 3:43 PM Michael S. Tsirkin wrote: > > No not yet. Sorry! Pls send this one in, barrier_data will likely miss > the next merge window. No worries! Done. Cheers, Miguel

Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-20 Thread Michael S. Tsirkin
On Sat, Jan 19, 2019 at 07:35:33PM +0100, Miguel Ojeda wrote: > Hi Michael, > > On Wed, Jan 9, 2019 at 3:50 PM Michael S. Tsirkin wrote: > > > > On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote: > > > Note it would be nice to separate the patch into two (one for the > > > comments, an

Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-19 Thread Miguel Ojeda
Hi Michael, On Wed, Jan 9, 2019 at 3:50 PM Michael S. Tsirkin wrote: > > On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote: > > Note it would be nice to separate the patch into two (one for the > > comments, another for OPTIMIZER_HIDE_VAR), and also possibly another > > for barrier_dat

Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-10 Thread Michael S. Tsirkin
On Thu, Jan 10, 2019 at 04:41:39PM +0300, Dan Carpenter wrote: > On Wed, Jan 09, 2019 at 09:36:41PM -0500, Michael S. Tsirkin wrote: > > On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote: > > > On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers > > > wrote: > > > > > > > > Also for more c

Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-10 Thread Dan Carpenter
On Wed, Jan 09, 2019 at 09:36:41PM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote: > > On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers > > wrote: > > > > > > Also for more context, see: > > > commit 7829fb09a2b4 ("lib: make memzero_explicit more ro

Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote: > On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers > wrote: > > > > Also for more context, see: > > commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against > > dead store elimination") > > By the way, shouldn't that barrie

Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2019 at 11:35:52AM +0100, Miguel Ojeda wrote: > On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers > wrote: > > > > Also for more context, see: > > commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against > > dead store elimination") > > By the way, shouldn't that barrie

Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-09 Thread Miguel Ojeda
On Tue, Jan 8, 2019 at 6:44 PM Nick Desaulniers wrote: > > Also for more context, see: > commit 7829fb09a2b4 ("lib: make memzero_explicit more robust against > dead store elimination") By the way, shouldn't that barrier_data() be directly in compiler.h too, since it is for both gcc & clang? > Re

Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-08 Thread Michael S. Tsirkin
On Tue, Jan 08, 2019 at 09:44:28AM -0800, Nick Desaulniers wrote: > Thanks for the patch and sorry for the delay; was totally unplugged > for the holidays. > On Wed, Jan 2, 2019 at 12:57 PM Michael S. Tsirkin wrote: > > > > Since commit 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h >

Re: [PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-08 Thread Nick Desaulniers
Thanks for the patch and sorry for the delay; was totally unplugged for the holidays. On Wed, Jan 2, 2019 at 12:57 PM Michael S. Tsirkin wrote: > > Since commit 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h > mutually exclusive") clang no longer reuses the OPTIMIZER_HIDE_VAR macro >

[PATCH RFC 1/4] include/linux/compiler*.h: fix OPTIMIZER_HIDE_VAR

2019-01-02 Thread Michael S. Tsirkin
Since commit 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually exclusive") clang no longer reuses the OPTIMIZER_HIDE_VAR macro from compiler-gcc - instead it gets the version in include/linux/compiler.h. Unfortunately that version doesn't actually prevent compiler from optimizin