Re: [PATCH RFC 1/2] vsock/virtio: fix kernel panic after device hot-unplug

2019-01-04 Thread Stefan Hajnoczi
On Thu, Jan 03, 2019 at 03:09:39PM +0100, Stefano Garzarella wrote: > On Thu, Jan 3, 2019 at 11:03 AM Stefan Hajnoczi wrote: > > > > On Wed, Jan 02, 2019 at 11:01:27AM +0100, Stefano Garzarella wrote: > > > On Wed, Jan 2, 2019 at 10:39 AM Stefan Hajnoczi > > > wrote: > > > > > > > > On Thu, Dec

Re: [PATCH RFC 1/2] vsock/virtio: fix kernel panic after device hot-unplug

2019-01-03 Thread Stefano Garzarella
On Thu, Jan 3, 2019 at 11:03 AM Stefan Hajnoczi wrote: > > On Wed, Jan 02, 2019 at 11:01:27AM +0100, Stefano Garzarella wrote: > > On Wed, Jan 2, 2019 at 10:39 AM Stefan Hajnoczi wrote: > > > > > > On Thu, Dec 20, 2018 at 01:15:34PM +0100, Stefano Garzarella wrote: > > > > diff --git a/net/vmw_vs

Re: [PATCH RFC 1/2] vsock/virtio: fix kernel panic after device hot-unplug

2019-01-03 Thread Stefan Hajnoczi
On Wed, Jan 02, 2019 at 11:01:27AM +0100, Stefano Garzarella wrote: > On Wed, Jan 2, 2019 at 10:39 AM Stefan Hajnoczi wrote: > > > > On Thu, Dec 20, 2018 at 01:15:34PM +0100, Stefano Garzarella wrote: > > > diff --git a/net/vmw_vsock/virtio_transport.c > > > b/net/vmw_vsock/virtio_transport.c > >

Re: [PATCH RFC 1/2] vsock/virtio: fix kernel panic after device hot-unplug

2019-01-02 Thread Stefano Garzarella
On Wed, Jan 2, 2019 at 10:39 AM Stefan Hajnoczi wrote: > > On Thu, Dec 20, 2018 at 01:15:34PM +0100, Stefano Garzarella wrote: > > diff --git a/net/vmw_vsock/virtio_transport.c > > b/net/vmw_vsock/virtio_transport.c > > index 5d3cce9e8744..9dae54698737 100644 > > --- a/net/vmw_vsock/virtio_transp

Re: [PATCH RFC 1/2] vsock/virtio: fix kernel panic after device hot-unplug

2019-01-02 Thread Stefan Hajnoczi
On Thu, Dec 20, 2018 at 01:15:34PM +0100, Stefano Garzarella wrote: > diff --git a/net/vmw_vsock/virtio_transport.c > b/net/vmw_vsock/virtio_transport.c > index 5d3cce9e8744..9dae54698737 100644 > --- a/net/vmw_vsock/virtio_transport.c > +++ b/net/vmw_vsock/virtio_transport.c > @@ -75,6 +75,9 @@ s

Re: [PATCH RFC 1/2] vsock/virtio: fix kernel panic after device hot-unplug

2018-12-20 Thread Stefano Garzarella
I fixed some mistakes in the commit text (for v2) On Thu, Dec 20, 2018 at 1:16 PM Stefano Garzarella wrote: > > virtio_vsock_remove() invoked the vsock_core_exit() also if there > are opened socket for the AF_VSOCK protocol family. In this way > the vsock "transport" pointer was set to NULL, trig

[PATCH RFC 1/2] vsock/virtio: fix kernel panic after device hot-unplug

2018-12-20 Thread Stefano Garzarella
virtio_vsock_remove() invoked the vsock_core_exit() also if there are opened socket for the AF_VSOCK protocol family. In this way the vsock "transport" pointer was set to NULL, triggering the kernel panic at the first socket activity. This patch move the vsock_core_init()/vsock_core_exit() in the