Re: [PATCH RFC 08/18] r8168: add basic phylib support

2017-12-22 Thread Andrew Lunn
On Thu, Dec 21, 2017 at 09:50:25PM +0100, Heiner Kallweit wrote: Hi Heiner This code looks good. Just a few minor comments. > +static int r8168_phy_connect(struct rtl8168_private *tp) > +{ > + struct phy_device *phydev; > + phy_interface_t phy_mode; > + int ret; > + > + phy_mode

[PATCH RFC 08/18] r8168: add basic phylib support

2017-12-21 Thread Heiner Kallweit
All PHY's of the supported chips are MII-compatible, therefore let phylib do the work. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/Kconfig | 1 + drivers/net/ethernet/realtek/r8168.c | 152 +++ 2 files changed, 120 insertions(+), 33 deletions