Re: [PATCH RFC] net: qualcomm: rmnet: Move common struct definitions to include

2019-05-21 Thread Subash Abhinov Kasiviswanathan
I think I'd just duplicate the structure definitions then, to avoid having the bitfield definitions in a common header and using them in the new driver. Doing would allow each driver to represent the bits as suitable, at the cost of some duplication and confusion. Confusion, because it doesn

Re: [PATCH RFC] net: qualcomm: rmnet: Move common struct definitions to include

2019-05-21 Thread Alex Elder
On 5/21/19 4:08 PM, Bjorn Andersson wrote: > On Tue 21 May 13:45 PDT 2019, Arnd Bergmann wrote: > >> On Tue, May 21, 2019 at 9:35 PM Subash Abhinov Kasiviswanathan >> wrote: >>> >>> Create if_rmnet.h and move the rmnet MAP packet structs to this >>> common include file. To account for portability

Re: [PATCH RFC] net: qualcomm: rmnet: Move common struct definitions to include

2019-05-21 Thread Bjorn Andersson
On Tue 21 May 13:45 PDT 2019, Arnd Bergmann wrote: > On Tue, May 21, 2019 at 9:35 PM Subash Abhinov Kasiviswanathan > wrote: > > > > Create if_rmnet.h and move the rmnet MAP packet structs to this > > common include file. To account for portability, add little and > > big endian bitfield definiti

Re: [PATCH RFC] net: qualcomm: rmnet: Move common struct definitions to include

2019-05-21 Thread Arnd Bergmann
On Tue, May 21, 2019 at 9:35 PM Subash Abhinov Kasiviswanathan wrote: > > Create if_rmnet.h and move the rmnet MAP packet structs to this > common include file. To account for portability, add little and > big endian bitfield definitions similar to the ip & tcp headers. > > The definitions in the

[PATCH RFC] net: qualcomm: rmnet: Move common struct definitions to include

2019-05-21 Thread Subash Abhinov Kasiviswanathan
Create if_rmnet.h and move the rmnet MAP packet structs to this common include file. To account for portability, add little and big endian bitfield definitions similar to the ip & tcp headers. The definitions in the headers can now be re-used by the upcoming ipa driver series as well as qmi_wwan.