Re: [PATCH RFC] net: mvneta: add ethtool statistics

2015-10-08 Thread Russell King - ARM Linux
On Thu, Oct 08, 2015 at 05:32:57PM +0200, Andrew Lunn wrote: > > > This would suggest the driver is not clearing the statistics when it > > > loads. Should it? > > > > That's an interesting question, one which I have no answer for. > > So i took a look at the other Marvell drivers. mv643xx_eth.c,

Re: [PATCH RFC] net: mvneta: add ethtool statistics

2015-10-08 Thread Andrew Lunn
> > This would suggest the driver is not clearing the statistics when it > > loads. Should it? > > That's an interesting question, one which I have no answer for. So i took a look at the other Marvell drivers. mv643xx_eth.c, skge and sky2.c all have code to clear the statistics. So for consistenc

Re: [PATCH RFC] net: mvneta: add ethtool statistics

2015-10-08 Thread Russell King - ARM Linux
On Thu, Oct 08, 2015 at 01:03:33AM +0200, Andrew Lunn wrote: > On Tue, Oct 06, 2015 at 09:41:08PM +0100, Russell King wrote: > > Add support for the ethtool statistic interface, returning the full set > > of statistics which both Armada 370 and Armada XP can support. > > > > Signed-off-by: Russell

Re: [PATCH RFC] net: mvneta: add ethtool statistics

2015-10-07 Thread Andrew Lunn
On Tue, Oct 06, 2015 at 09:41:08PM +0100, Russell King wrote: > Add support for the ethtool statistic interface, returning the full set > of statistics which both Armada 370 and Armada XP can support. > > Signed-off-by: Russell King > --- > Andrew, > > Here's the patch updated to use the example

Re: [PATCH RFC] net: mvneta: add ethtool statistics

2015-10-06 Thread Russell King
Add support for the ethtool statistic interface, returning the full set of statistics which both Armada 370 and Armada XP can support. Signed-off-by: Russell King --- Andrew, Here's the patch updated to use the example set by mv643xx_eth.c. drivers/net/ethernet/marvell/mvneta.c | 99 ++