Re: [PATCH RFC] net/mlx5_en: switch to Toeplitz RSS hash by default

2018-09-06 Thread Konstantin Khlebnikov
On 06.09.2018 08:24, Saeed Mahameed wrote: On Sun, Sep 2, 2018 at 2:55 AM, Konstantin Khlebnikov wrote: On 02.09.2018 12:29, Tariq Toukan wrote: On 31/08/2018 2:29 PM, Konstantin Khlebnikov wrote: XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits. It seems not enough for RFS. All o

Re: [PATCH RFC] net/mlx5_en: switch to Toeplitz RSS hash by default

2018-09-05 Thread Saeed Mahameed
On Sun, Sep 2, 2018 at 2:55 AM, Konstantin Khlebnikov wrote: > On 02.09.2018 12:29, Tariq Toukan wrote: >> >> >> >> On 31/08/2018 2:29 PM, Konstantin Khlebnikov wrote: >>> >>> XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits. >>> It seems not enough for RFS. All other drivers use toeplitz. >>

Re: [PATCH RFC] net/mlx5_en: switch to Toeplitz RSS hash by default

2018-09-02 Thread Konstantin Khlebnikov
On 02.09.2018 12:29, Tariq Toukan wrote: On 31/08/2018 2:29 PM, Konstantin Khlebnikov wrote: XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits. It seems not enough for RFS. All other drivers use toeplitz. Driver mlx4_en uses Toeplitz by default and warns if hash XOR is used together with

Re: [PATCH RFC] net/mlx5_en: switch to Toeplitz RSS hash by default

2018-09-02 Thread Tariq Toukan
On 31/08/2018 2:29 PM, Konstantin Khlebnikov wrote: XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits. It seems not enough for RFS. All other drivers use toeplitz. Driver mlx4_en uses Toeplitz by default and warns if hash XOR is used together with NETIF_F_RXHASH (enabled by default too):

[PATCH RFC] net/mlx5_en: switch to Toeplitz RSS hash by default

2018-08-31 Thread Konstantin Khlebnikov
XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits. It seems not enough for RFS. All other drivers use toeplitz. Driver mlx4_en uses Toeplitz by default and warns if hash XOR is used together with NETIF_F_RXHASH (enabled by default too): "Enabling both XOR Hash function and RX Hashing can limit