RE: [PATCH RFC] ethernet: stmmac: clean up the code for release/suspend/resume function

2020-12-11 Thread Joakim Zhang
Re: [PATCH RFC] ethernet: stmmac: clean up the code for > release/suspend/resume function > > > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > > > @@ -2908,8 +2908,7 @@ static int

Re: [PATCH RFC] ethernet: stmmac: clean up the code for release/suspend/resume function

2020-12-10 Thread Jisheng Zhang
davemloft.net; k...@kernel.org; > > netdev@vger.kernel.org; dl-linux-imx > > Subject: Re: [PATCH RFC] ethernet: stmmac: clean up the code for > > release/suspend/resume function > > > > On Mon, 7 Dec 2020 19:38:49 +0800 Joakim Zhang wrote: > > > >

RE: [PATCH RFC] ethernet: stmmac: clean up the code for release/suspend/resume function

2020-12-08 Thread Joakim Zhang
CH RFC] ethernet: stmmac: clean up the code for > release/suspend/resume function > > On Mon, 7 Dec 2020 19:38:49 +0800 Joakim Zhang wrote: > > > > > > commit 1c35cc9cf6a0 ("net: stmmac: remove redundant null check before > > clk_disable_unprepare()"

Re: [PATCH RFC] ethernet: stmmac: clean up the code for release/suspend/resume function

2020-12-08 Thread Jisheng Zhang
On Mon, 7 Dec 2020 19:38:49 +0800 Joakim Zhang wrote: > > commit 1c35cc9cf6a0 ("net: stmmac: remove redundant null check before > clk_disable_unprepare()"), > have not clean up check NULL clock parameter completely, this patch did it. > > commit e8377e7a29efb ("net: stmmac: only call pmt() du

[PATCH RFC] ethernet: stmmac: clean up the code for release/suspend/resume function

2020-12-07 Thread Joakim Zhang
commit 1c35cc9cf6a0 ("net: stmmac: remove redundant null check before clk_disable_unprepare()"), have not clean up check NULL clock parameter completely, this patch did it. commit e8377e7a29efb ("net: stmmac: only call pmt() during suspend/resume if HW enables PMT"), after this patch, we use if