Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

> On Nov 9, 2020, at 3:10 PM, Eric Dumazet wrote: > > > > On 11/9/20 8:31 PM, Chuck Lever wrote: >> >> >>> On Nov 9, 2020, at 1:16 PM, Trond Myklebust wrote: >>> >>> On Mon, 2020-11-09 at 12:36 -0500, Chuck Lever wrote: > On Nov 9, 2020, at 12:32 PM, Trond Myklebust < >>>

Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

> On Nov 9, 2020, at 3:10 PM, Eric Dumazet wrote: > > > > On 11/9/20 8:31 PM, Chuck Lever wrote: >> >> >>> On Nov 9, 2020, at 1:16 PM, Trond Myklebust wrote: >>> >>> On Mon, 2020-11-09 at 12:36 -0500, Chuck Lever wrote: > On Nov 9, 2020, at 12:32 PM, Trond Myklebust < >>>

Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

On 11/9/20 8:31 PM, Chuck Lever wrote: > > >> On Nov 9, 2020, at 1:16 PM, Trond Myklebust wrote: >> >> On Mon, 2020-11-09 at 12:36 -0500, Chuck Lever wrote: >>> >>> On Nov 9, 2020, at 12:32 PM, Trond Myklebust < tron...@hammerspace.com> wrote: On Mon, 2020-11-09 at 12:12 -

Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

> On Nov 9, 2020, at 1:16 PM, Trond Myklebust wrote: > > On Mon, 2020-11-09 at 12:36 -0500, Chuck Lever wrote: >> >> >>> On Nov 9, 2020, at 12:32 PM, Trond Myklebust < >>> tron...@hammerspace.com> wrote: >>> >>> On Mon, 2020-11-09 at 12:12 -0500, Chuck Lever wrote: > On Nov

Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

On Mon, 2020-11-09 at 12:36 -0500, Chuck Lever wrote: > > > > On Nov 9, 2020, at 12:32 PM, Trond Myklebust < > > tron...@hammerspace.com> wrote: > > > > On Mon, 2020-11-09 at 12:12 -0500, Chuck Lever wrote: > > > > > > > > > > On Nov 9, 2020, at 12:08 PM, Trond Myklebust > > > > wrote: > > >

Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

On Mon, Nov 09, 2020 at 12:36:15PM -0500, Chuck Lever wrote: > > On Nov 9, 2020, at 12:32 PM, Trond Myklebust > > wrote: > > On Mon, 2020-11-09 at 12:12 -0500, Chuck Lever wrote: > >> I assume you mean the client side only. Those issues aren't a factor > >> on the server. Not setting SOCK_ZEROCOP

Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

> On Nov 9, 2020, at 12:32 PM, Trond Myklebust wrote: > > On Mon, 2020-11-09 at 12:12 -0500, Chuck Lever wrote: >> >> >>> On Nov 9, 2020, at 12:08 PM, Trond Myklebust >>> wrote: >>> >>> On Mon, 2020-11-09 at 11:03 -0500, Chuck Lever wrote: Daire Byrne reports a ~50% aggregrate through

Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

On Mon, 2020-11-09 at 12:12 -0500, Chuck Lever wrote: > > > > On Nov 9, 2020, at 12:08 PM, Trond Myklebust > > wrote: > > > > On Mon, 2020-11-09 at 11:03 -0500, Chuck Lever wrote: > > > Daire Byrne reports a ~50% aggregrate throughput regression on > > > his > > > Linux NFS server after commit

Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

> On Nov 9, 2020, at 12:08 PM, Trond Myklebust wrote: > > On Mon, 2020-11-09 at 11:03 -0500, Chuck Lever wrote: >> Daire Byrne reports a ~50% aggregrate throughput regression on his >> Linux NFS server after commit da1661b93bf4 ("SUNRPC: Teach server to >> use xprt_sock_sendmsg for socket send

Re: [PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

On Mon, 2020-11-09 at 11:03 -0500, Chuck Lever wrote: > Daire Byrne reports a ~50% aggregrate throughput regression on his > Linux NFS server after commit da1661b93bf4 ("SUNRPC: Teach server to > use xprt_sock_sendmsg for socket sends"), which replaced > kernel_send_page() calls in NFSD's socket se

[PATCH RFC] SUNRPC: Use zero-copy to perform socket send operations

Daire Byrne reports a ~50% aggregrate throughput regression on his Linux NFS server after commit da1661b93bf4 ("SUNRPC: Teach server to use xprt_sock_sendmsg for socket sends"), which replaced kernel_send_page() calls in NFSD's socket send path with calls to sock_sendmsg() using iov_iter. Investig