Re: [PATCH RFC] Clean up sk_buff walkers

2007-04-26 Thread David Miller
From: Jean Delvare <[EMAIL PROTECTED]> Date: Tue, 20 Mar 2007 08:19:49 +0100 > Hi all, > > I noticed recently that, in skb_checksum(), "offset" and "start" are > essentially the same thing and have the same value throughout the > function, despite being computed differently. Using a single variab

Re: [PATCH RFC] Clean up sk_buff walkers

2007-04-20 Thread David Miller
From: Jean Delvare <[EMAIL PROTECTED]> Date: Wed, 4 Apr 2007 18:03:04 +0200 > Hmm, no comment? The cleanup seems worth the effort, both for source > code readability and binary size. It's still in my patch backlog do not worry :-) I will get to it eventually. - To unsubscribe from this list: sen

Re: [PATCH RFC] Clean up sk_buff walkers

2007-04-04 Thread Jean Delvare
Le Mardi 20 Mars 2007 08:19, Jean Delvare a écrit : > I noticed recently that, in skb_checksum(), "offset" and "start" are > essentially the same thing and have the same value throughout the > function, despite being computed differently. Using a single variable > allows some cleanups and makes the

[PATCH RFC] Clean up sk_buff walkers

2007-03-19 Thread Jean Delvare
Hi all, I noticed recently that, in skb_checksum(), "offset" and "start" are essentially the same thing and have the same value throughout the function, despite being computed differently. Using a single variable allows some cleanups and makes the skb_checksum() function smaller, more readable, an