Re: [PATCH RESEND net-next v2] KEYS: DNS: limit the length of option strings

2018-04-17 Thread David Miller
From: Eric Biggers Date: Tue, 17 Apr 2018 11:37:36 -0700 > On Tue, Apr 17, 2018 at 02:24:37PM -0400, David Miller wrote: >> From: Eric Biggers >> Date: Tue, 17 Apr 2018 11:23:40 -0700 >> >> > Can you queue this up for stable too? syzbot has been hitting this on >> > older >> > kernel versions

Re: [PATCH RESEND net-next v2] KEYS: DNS: limit the length of option strings

2018-04-17 Thread Eric Biggers
On Tue, Apr 17, 2018 at 02:24:37PM -0400, David Miller wrote: > From: Eric Biggers > Date: Tue, 17 Apr 2018 11:23:40 -0700 > > > Can you queue this up for stable too? syzbot has been hitting this on older > > kernel versions. > > If you want a patch bound for stable, it must show up in Linus's

Re: [PATCH RESEND net-next v2] KEYS: DNS: limit the length of option strings

2018-04-17 Thread David Miller
From: Eric Biggers Date: Tue, 17 Apr 2018 11:23:40 -0700 > Can you queue this up for stable too? syzbot has been hitting this on older > kernel versions. If you want a patch bound for stable, it must show up in Linus's tree first which means you should target 'net' rather than 'net-next'.

Re: [PATCH RESEND net-next v2] KEYS: DNS: limit the length of option strings

2018-04-17 Thread Eric Biggers
On Tue, Apr 17, 2018 at 01:43:16PM -0400, David Miller wrote: > From: Eric Biggers > Date: Mon, 16 Apr 2018 14:29:22 -0700 > > > From: Eric Biggers > > > > Adding a dns_resolver key whose payload contains a very long option name > > resulted in that string being printed in full. This hit the W

Re: [PATCH RESEND net-next v2] KEYS: DNS: limit the length of option strings

2018-04-17 Thread David Miller
From: Eric Biggers Date: Mon, 16 Apr 2018 14:29:22 -0700 > From: Eric Biggers > > Adding a dns_resolver key whose payload contains a very long option name > resulted in that string being printed in full. This hit the WARN_ONCE() > in set_precision() during the printk(), because printk() only s

[PATCH RESEND net-next v2] KEYS: DNS: limit the length of option strings

2018-04-16 Thread Eric Biggers
From: Eric Biggers Adding a dns_resolver key whose payload contains a very long option name resulted in that string being printed in full. This hit the WARN_ONCE() in set_precision() during the printk(), because printk() only supports a precision of up to 32767 bytes: precision 100 too