Re: [PATCH RESEND net-next 13/15] smc: receive data from RMBE

2016-09-02 Thread David Miller
From: Ursula Braun Date: Fri, 2 Sep 2016 15:05:01 +0200 > Understood, I wrongly used xchg() for atomicity. I now realize that I > would need cursor locking for 32-bit architectures - something I would > like to defer. Thus I would like to come up with V2 of SMC-R with > builds restricted to 64-bi

Re: [PATCH RESEND net-next 13/15] smc: receive data from RMBE

2016-09-02 Thread Ursula Braun
Dave, sorry for the late answer; I had to interrupt my SMC-R activities for a while; now I can continue ... On 08/10/2016 07:45 PM, David Miller wrote: From: Ursula Braun Date: Wed, 10 Aug 2016 15:44:00 +0200 But there are still usages (and conn->rx_curs_confirmed is one of them), where I

Re: [PATCH RESEND net-next 13/15] smc: receive data from RMBE

2016-08-10 Thread David Miller
From: Ursula Braun Date: Wed, 10 Aug 2016 15:44:00 +0200 > But there are still usages (and conn->rx_curs_confirmed is one of > them), where I need an 8-byte cursor field to be read and written > atomicaly, even though I do not care whether the write operation has > been beaten or not. But I do ca

Re: [PATCH RESEND net-next 13/15] smc: receive data from RMBE

2016-08-10 Thread Ursula Braun
On 08/09/2016 11:32 PM, David Miller wrote: From: Ursula Braun Date: Tue, 9 Aug 2016 12:12:58 +0200 + xchg(&conn->rx_curs_confirmed.acurs, +smc_curs_read(conn->local_tx_ctrl.cons.acurs)); Why in the world do you need to use xchg() in all of these places?

Fwd: Re: [PATCH RESEND net-next 13/15] smc: receive data from RMBE

2016-08-10 Thread Ursula Braun
Dave, sorry, forget my previous mail from today. I now realize that xchg() does not help on 32-bit architectures. I have to think about alternatives here. Forwarded Message Subject: Re: [PATCH RESEND net-next 13/15] smc: receive data from RMBE Date: Wed, 10 Aug 2016 15:44

Re: [PATCH RESEND net-next 13/15] smc: receive data from RMBE

2016-08-09 Thread David Miller
From: Ursula Braun Date: Tue, 9 Aug 2016 12:12:58 +0200 > + xchg(&conn->rx_curs_confirmed.acurs, > + smc_curs_read(conn->local_tx_ctrl.cons.acurs)); Why in the world do you need to use xchg() in all of these places? It makes no sense whatsoever, especially since yo

[PATCH RESEND net-next 13/15] smc: receive data from RMBE

2016-08-09 Thread Ursula Braun
move RMBE data into user space buffer and update managing cursors Signed-off-by: Ursula Braun --- net/smc/Makefile | 2 +- net/smc/af_smc.c | 7 +- net/smc/smc.h | 4 + net/smc/smc_cdc.c | 6 +- net/smc/smc_core.c | 10 +++ net/smc/smc_rx.c | 212