Re: [PATCH RESEND net-next] netlink: add tracepoint at NL_SET_ERR_MSG

2021-02-03 Thread Jakub Kicinski
On Mon, 1 Feb 2021 15:12:19 -0300 Marcelo Ricardo Leitner wrote: > Often userspace won't request the extack information, or they don't log it > because of log level or so, and even when they do, sometimes it's not > enough to know exactly what caused the error. > > Netlink extack is the standard

Re: [PATCH RESEND net-next] netlink: add tracepoint at NL_SET_ERR_MSG

2021-02-02 Thread Marcelo Ricardo Leitner
On Tue, Feb 02, 2021 at 09:16:28AM -0700, David Ahern wrote: > On 2/2/21 5:30 AM, Marcelo Ricardo Leitner wrote: > > > > Also, if the message is a common one, one may not be able to easily > > distinguish them. Ideally this shouldn't happen, but when debugging > > applications such as OVS, where l

Re: [PATCH RESEND net-next] netlink: add tracepoint at NL_SET_ERR_MSG

2021-02-02 Thread David Ahern
On 2/2/21 5:30 AM, Marcelo Ricardo Leitner wrote: > > Also, if the message is a common one, one may not be able to easily > distinguish them. Ideally this shouldn't happen, but when debugging > applications such as OVS, where lots of netlink requests are flying, > it saves us time. I can, for exam

Re: [PATCH RESEND net-next] netlink: add tracepoint at NL_SET_ERR_MSG

2021-02-02 Thread Marcelo Ricardo Leitner
On Mon, Feb 01, 2021 at 05:34:00PM -0800, Jakub Kicinski wrote: > On Mon, 1 Feb 2021 15:12:19 -0300 Marcelo Ricardo Leitner wrote: > > Often userspace won't request the extack information, or they don't log it > > because of log level or so, and even when they do, sometimes it's not > > enough to

Re: [PATCH RESEND net-next] netlink: add tracepoint at NL_SET_ERR_MSG

2021-02-01 Thread Jakub Kicinski
On Mon, 1 Feb 2021 15:12:19 -0300 Marcelo Ricardo Leitner wrote: > Often userspace won't request the extack information, or they don't log it > because of log level or so, and even when they do, sometimes it's not > enough to know exactly what caused the error. > > Netlink extack is the standard

[PATCH RESEND net-next] netlink: add tracepoint at NL_SET_ERR_MSG

2021-02-01 Thread Marcelo Ricardo Leitner
Often userspace won't request the extack information, or they don't log it because of log level or so, and even when they do, sometimes it's not enough to know exactly what caused the error. Netlink extack is the standard way of reporting erros with descriptive error messages. With a trace point o