> On 07/15/2016 07:25 AM, Stanislaw Gruszka wrote:
> > On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote:
> >>> If I understad correctly this error happen 100% of the time, not
> >>> only during init. Hence seems there is an issue here, i.e. cur_ucode
> >>> is not marked correctly
On 07/15/2016 07:25 AM, Stanislaw Gruszka wrote:
> On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote:
>>> If I understad correctly this error happen 100% of the time, not only during
>>> init. Hence seems there is an issue here, i.e. cur_ucode is not marked
>>> correctly as IWL_U
On Thu, Jul 14, 2016 at 09:44:22AM +, Grumbach, Emmanuel wrote:
> > If I understad correctly this error happen 100% of the time, not only during
> > init. Hence seems there is an issue here, i.e. cur_ucode is not marked
> > correctly as IWL_UCODE_REGULAR or iwl_mvm_get_temp() fail 100% of the
>
>
> On Mon, Jul 11, 2016 at 06:27:30PM +, Grumbach, Emmanuel wrote:
> > I guess that works, but it seems wrong to me. Usually, registration
> > should happen only upon INIT, and yes, at that time the firmware is
> > not ready to provide the information yet.
>
> > >
> > > As can be seen in the
On Mon, Jul 11, 2016 at 06:27:30PM +, Grumbach, Emmanuel wrote:
> I guess that works, but it seems wrong to me. Usually, registration
> should happen only upon INIT, and yes, at that time the firmware is not
> ready to provide the information yet.
> >
> > As can be seen in the current code ba
>
> Prarit Bhargava writes:
>
> > On 07/13/2016 03:24 AM, Luca Coelho wrote:
> >
> >> I totally agree with Emmanuel and Kalle. We should not change this.
> >> It is a design decision to return an error when the interface is
> >> down, this is very common with other subsystems as well.
> >
> > Pl
Prarit Bhargava writes:
> On 07/13/2016 03:24 AM, Luca Coelho wrote:
>
>> I totally agree with Emmanuel and Kalle. We should not change this.
>> It is a design decision to return an error when the interface is
>> down, this is very common with other subsystems as well.
>
> Please show me another
Prarit Bhargava writes:
> On 07/13/2016 02:50 AM, Kalle Valo wrote:
>> Prarit Bhargava writes:
>>
We implement thermal zone because we do support it, but the problem is
that we need the firmware to be loaded for that. So you can argue that
we should register *later* when the firm
On 07/13/2016 03:24 AM, Luca Coelho wrote:
> On Wed, 2016-07-13 at 09:50 +0300, Kalle Valo wrote:
>> Prarit Bhargava writes:
>>
We implement thermal zone because we do support it, but the
problem is
that we need the firmware to be loaded for that. So you can argue
that
w
On 07/13/2016 02:50 AM, Kalle Valo wrote:
> Prarit Bhargava writes:
>
>>> We implement thermal zone because we do support it, but the problem is
>>> that we need the firmware to be loaded for that. So you can argue that
>>> we should register *later* when the firmware is loaded. But this is
>>>
On Wed, 2016-07-13 at 09:50 +0300, Kalle Valo wrote:
> Prarit Bhargava writes:
>
> > > We implement thermal zone because we do support it, but the
> > > problem is
> > > that we need the firmware to be loaded for that. So you can argue
> > > that
> > > we should register *later* when the firmware
Prarit Bhargava writes:
>> We implement thermal zone because we do support it, but the problem is
>> that we need the firmware to be loaded for that. So you can argue that
>> we should register *later* when the firmware is loaded. But this is
>> really not helping all that much because the firmwa
On 07/11/2016 02:27 PM, Grumbach, Emmanuel wrote:
> On Mon, 2016-07-11 at 14:19 -0400, Prarit Bhargava wrote:
>>
>> On 07/11/2016 02:00 PM, Emmanuel Grumbach wrote:
>>> On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava >>> wrote:
Didn't get any feedback or review comments on this patch.
On Mon, 2016-07-11 at 14:19 -0400, Prarit Bhargava wrote:
>
> On 07/11/2016 02:00 PM, Emmanuel Grumbach wrote:
> > On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava > > wrote:
> > >
> > > Didn't get any feedback or review comments on this patch.
> > > Resending ...
> > >
> > > P.
> >
> > This
On 07/11/2016 02:00 PM, Emmanuel Grumbach wrote:
> On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava wrote:
>>
>> Didn't get any feedback or review comments on this patch. Resending ...
>>
>> P.
>
> This change is obviously completely broken. It simply disables the
> registration to thermal zon
On Mon, Jul 11, 2016 at 6:18 PM, Prarit Bhargava wrote:
>
> Didn't get any feedback or review comments on this patch. Resending ...
>
> P.
This change is obviously completely broken. It simply disables the
registration to thermal zone core.
>
> ---8<---
>
> The iwlwifi driver implements a therm
On 07/11/2016 12:07 PM, Coelho, Luciano wrote:
> On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote:
>> Didn't get any feedback or review comments on this patch. Resending
>> ...
>>
>> P.
>
> Sorry, this got flooded down my inbox.
NP, Luciano -- My worry was that it hadn't been seen or d
On Mon, 2016-07-11 at 11:18 -0400, Prarit Bhargava wrote:
> Didn't get any feedback or review comments on this patch. Resending
> ...
>
> P.
Sorry, this got flooded down my inbox.
> ---8<---
>
> The iwlwifi driver implements a thermal zone and hwmon device, but
> returns -EIO on temperature r
Didn't get any feedback or review comments on this patch. Resending ...
P.
---8<---
The iwlwifi driver implements a thermal zone and hwmon device, but
returns -EIO on temperature reads if the firmware isn't loaded. This
results in the error
iwlwifi-virtual-0
Adapter: Virtual device
ERROR: Can
19 matches
Mail list logo
