Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-26 Thread Steve Wise
On Mon, 2006-06-26 at 10:43 -0700, David Miller wrote: > From: Steve Wise <[EMAIL PROTECTED]> > Date: Mon, 26 Jun 2006 10:26:11 -0500 > > > I guess what I think we should do is pass the fib_info * when its a IPv4 > > route add/del, and a rt6_info * when its a IPv6 add/del. This avoids > > having

Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-26 Thread David Miller
From: Steve Wise <[EMAIL PROTECTED]> Date: Mon, 26 Jun 2006 10:26:11 -0500 > I guess what I think we should do is pass the fib_info * when its a IPv4 > route add/del, and a rt6_info * when its a IPv6 add/del. This avoids > having to create some new family independent struct. What I'll have to >

Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-26 Thread Steve Wise
On Fri, 2006-06-23 at 13:26 -0700, David Miller wrote: > From: Steve Wise <[EMAIL PROTECTED]> > Date: Fri, 23 Jun 2006 15:19:28 -0500 > > > +struct netevent_route_change { > > +int event; > > +struct fib_info *fib_info; > > +}; > > It's not generic if you're putting ipv4 FIB route

Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-23 Thread Steve Wise
- Original Message - From: "David Miller" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Cc: Sent: Friday, June 23, 2006 3:56 PM Subject: Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism. | From: Steve Wise <[EMAIL PROTECTED]> | Date: Fri, 23 Jun 2006 1

Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-23 Thread David Miller
From: Steve Wise <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 15:34:55 -0500 > But what about the redirect event? It really needs to pass two bits of > info: The old dst_entry ptr and the new dst_entry ptr. This is needed > so the rdma driver can figure out which connections now need to use the >

Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-23 Thread Steve Wise
On Fri, 2006-06-23 at 13:26 -0700, David Miller wrote: > From: Steve Wise <[EMAIL PROTECTED]> > Date: Fri, 23 Jun 2006 15:19:28 -0500 > > > +struct netevent_route_change { > > +int event; > > +struct fib_info *fib_info; > > +}; > > It's not generic if you're putting ipv4 FIB route

Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-23 Thread David Miller
From: Steve Wise <[EMAIL PROTECTED]> Date: Fri, 23 Jun 2006 15:19:28 -0500 > +struct netevent_route_change { > +int event; > +struct fib_info *fib_info; > +}; It's not generic if you're putting ipv4 FIB route objects in the datastructure. This is so much unnecessary syntactic sug

[PATCH REPOST 1/2] Network Event Notifier Mechanism.

2006-06-23 Thread Steve Wise
This patch uses notifier blocks to implement a network event notifier mechanism. Clients register their callback function by calling register_netevent_notifier() like this: static struct notifier_block nb = { .notifier_call = my_callback_func }; ... register_netevent_notifier(&nb); ---