Re: [PATCH NET V7 0/2] Add loopback support in phy_driver and hns ethtool fix

2017-06-29 Thread Yunsheng Lin
Hi, David I will send out a patch based on net-next, and I will continue to address the problem andrew pointed out. If I come out with a doable solution, I will send out the new patch. Best Regards Yunsheng Lin On 2017/6/30 4:08, David Miller wrote: > From: Andrew Lunn > Date: Thu, 29 Jun 2017

Re: [PATCH NET V7 0/2] Add loopback support in phy_driver and hns ethtool fix

2017-06-29 Thread David Miller
From: Andrew Lunn Date: Thu, 29 Jun 2017 20:22:16 +0200 Is less broken a sufficient criteria for acceptance? Sometimes, it depends upon the situation. If you are continuing to resolve those issues, I'll wait and watch for future respins then.

Re: [PATCH NET V7 0/2] Add loopback support in phy_driver and hns ethtool fix

2017-06-29 Thread Andrew Lunn
On Thu, Jun 29, 2017 at 02:14:55PM -0400, David Miller wrote: > From: Lin Yun Sheng > Date: Wed, 28 Jun 2017 17:13:09 +0800 > > > This Patch Set add set_loopback in phy_driver and use it to setup loopback > > when doing ethtool phy self_test. > > This doesn't apply cleanly to the net-next tree,

Re: [PATCH NET V7 0/2] Add loopback support in phy_driver and hns ethtool fix

2017-06-29 Thread David Miller
From: Lin Yun Sheng Date: Wed, 28 Jun 2017 17:13:09 +0800 > This Patch Set add set_loopback in phy_driver and use it to setup loopback > when doing ethtool phy self_test. This doesn't apply cleanly to the net-next tree, please respin. Thank you.

[PATCH NET V7 0/2] Add loopback support in phy_driver and hns ethtool fix

2017-06-28 Thread Lin Yun Sheng
This Patch Set add set_loopback in phy_driver and use it to setup loopback when doing ethtool phy self_test. Patch V7: 1. Add comment why resume the phy in hns_nic_config_phy_loopback. 2. Fix a typo error in patch description. Patch V6: Fix Or'ing error code in __lb_setup.