Re: [PATCH NET V4 1/2] net: phy: Add phy loopback support in net phy framework

2017-06-25 Thread Yunsheng Lin
Hi, Andrew On 2017/6/24 21:44, Andrew Lunn wrote: >> @@ -1087,7 +1087,7 @@ int phy_suspend(struct phy_device *phydev) >> { >> struct phy_driver *phydrv = to_phy_driver(phydev->mdio.dev.driver); >> struct ethtool_wolinfo wol = { .cmd = ETHTOOL_GWOL }; >> -int ret = 0; >> +int ret

Re: [PATCH NET V4 1/2] net: phy: Add phy loopback support in net phy framework

2017-06-24 Thread Andrew Lunn
> @@ -1087,7 +1087,7 @@ int phy_suspend(struct phy_device *phydev) > { > struct phy_driver *phydrv = to_phy_driver(phydev->mdio.dev.driver); > struct ethtool_wolinfo wol = { .cmd = ETHTOOL_GWOL }; > - int ret = 0; > + int ret = -EOPNOTSUPP; > > /* If the device has WOL

[PATCH NET V4 1/2] net: phy: Add phy loopback support in net phy framework

2017-06-24 Thread Lin Yun Sheng
This patch add set_loopback in phy_driver, which is used by Mac driver to enable or disable a phy. it also add a generic genphy_loopback function, which use BMCR loopback bit to enable or disable a phy. Signed-off-by: Lin Yun Sheng --- drivers/net/phy/marvell.c| 1 + drivers/net/phy/phy_dev