Re: [PATCH 9/9] net_device: dont include wext bits if not required

2007-04-26 Thread John W. Linville
On Thu, Apr 26, 2007 at 09:53:04AM -0700, Jean Tourrilhes wrote: > On Tue, Apr 24, 2007 at 08:07:41PM +0200, Johannes Berg wrote: > > This patch makes the wext bits in struct net_device depend on > > CONFIG_WIRELESS_EXT. > > > > Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> > > I persona

Re: [PATCH 9/9] net_device: dont include wext bits if not required

2007-04-26 Thread Johannes Berg
On Thu, 2007-04-26 at 09:53 -0700, Jean Tourrilhes wrote: > I personally would not do that. Having conditional fields in > "struct net_device" is very bad, it's a sure way to crash on modules > in some cases. If I remember well, Jeff Garzik has been fighting those > over the years. I'm fine

Re: [PATCH 9/9] net_device: dont include wext bits if not required

2007-04-26 Thread Jean Tourrilhes
On Tue, Apr 24, 2007 at 08:07:41PM +0200, Johannes Berg wrote: > This patch makes the wext bits in struct net_device depend on > CONFIG_WIRELESS_EXT. > > Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> I personally would not do that. Having conditional fields in "struct net_device" is ve

[PATCH 9/9] net_device: dont include wext bits if not required

2007-04-26 Thread Johannes Berg
This patch makes the wext bits in struct net_device depend on CONFIG_WIRELESS_EXT. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- include/linux/netdevice.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- net-2.6.22.orig/include/linux/netdevice.h 2007-04-24 19:36:59.248804