Don Fry <[EMAIL PROTECTED]> :
[...]
> > No need to save/restore (it's true in pcnet32_{get_regs/suspend} too).
>
> This lock is taken by the interrupt handler and my reading of
> spinlocks.txt says I do need to use spin_lock_irqsave unless I
> misunderstand. The only spin_lock() is in the interru
On Fri, Jun 30, 2006 at 12:24:38AM +0200, Francois Romieu wrote:
> Nit below.
>
> Don Fry <[EMAIL PROTECTED]> :
> [...]
> > --- linux-2.6.17-git13/drivers/net/purge.pcnet32.c Thu Jun 29 13:28:24 2006
> > +++ linux-2.6.17-git13/drivers/net/pcnet32.cThu Jun 29 13:28:31 2006
> [...]
> > +#if
Nit below.
Don Fry <[EMAIL PROTECTED]> :
[...]
> --- linux-2.6.17-git13/drivers/net/purge.pcnet32.cThu Jun 29 13:28:24 2006
> +++ linux-2.6.17-git13/drivers/net/pcnet32.c Thu Jun 29 13:28:31 2006
[...]
> +#ifdef CONFIG_PCNET32_NAPI
> +static int pcnet32_poll(struct net_device *dev, int *budge
Implement NAPI changes to pcnet32 driver. Compile default is off.
Listed as experimental.
Len and Don both worked on a NAPI implementation and have both tested
these changes.
An e1000 blasting short packets to the pcnet32 will lockup Don's system
until the receive storm stops. Without NAPI Le
