Re: [PATCH 7/9] sky2: power down PHY when not up

2006-08-29 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: To save power, don't enable power to the PHY until device is brought up. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Strongly agree, and ACK, but note that users have complained in the past when they could not configure their MAC when the interface was down.

Re: [PATCH 7/9] sky2: power down PHY when not up

2006-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2006 17:04:59 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > To save power, don't enable power to the PHY until device is brought up. > > > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > Strongly agree, and ACK, but note that users have com

[PATCH 7/9] sky2: power down PHY when not up

2006-08-28 Thread shemminger
To save power, don't enable power to the PHY until device is brought up. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-08-28 10:00:13.0 -0700 +++ sky2/drivers/net/sky2.c 2006-08-28 10:00:17.0 -0700 @@ -195,7 +195,6 @@ static