Re: [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it

2019-03-25 Thread Bart Van Assche
On Fri, 2019-03-22 at 18:46 +, Rustad, Mark D wrote: > This doesn't look right to me. The original code seemingly would stop the > copy before getting to a possible '%' character. The new code only stops at > eol. So this appears to change the functionality and I assume is broken in > any

Re: [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it

2019-03-22 Thread Rustad, Mark D
On Mar 21, 2019, at 3:19 PM, Bart Van Assche wrote: This patch does not change any functionality but makes the code easier to read. Cc: Sagi Grimberg Cc: Christoph Hellwig Signed-off-by: Bart Van Assche --- net/core/utils.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff -

Re: [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it

2019-03-21 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

[PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it

2019-03-21 Thread Bart Van Assche
This patch does not change any functionality but makes the code easier to read. Cc: Sagi Grimberg Cc: Christoph Hellwig Signed-off-by: Bart Van Assche --- net/core/utils.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/core/utils.c b/net/core/utils.c index 2a597ac