Re: [PATCH 6/7] [DCCP]: Fix setting of packet size in CCID3

2006-09-22 Thread Eddie Kohler
| +case DCCP_SOCKOPT_TX_PACKET_SIZE: | +if (dmsk->dccpms_tx_ccid != DCCPC_CCID3) | +err = -EINVAL; This is unfortunate: it is in the generic dccp code but works only for CCID 3. Same for DCCP_SOCKOPT_RX_PACKET_SIZE. I agree with Gerrit. An average packet s

Re: [PATCH 6/7] [DCCP]: Fix setting of packet size in CCID3

2006-09-22 Thread Gerrit Renker
Quoting Ian McDonald: | Set initial packet size to defaults as existing code doesn't work | as set_sockopt occurs after initialisation so dccps_packet_size | is of no use really. Please see comments to patch 5/7; rather than setting a default, ccid3hc{rx,tx}_s should be derived from incoming/out

[PATCH 6/7] [DCCP]: Fix setting of packet size in CCID3

2006-09-21 Thread Ian McDonald
Set initial packet size to defaults as existing code doesn't work as set_sockopt occurs after initialisation so dccps_packet_size is of no use really. Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> --- diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index 7b4699a..e6c8e4c 100644 ---