Re: [PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes on 64-bit arch

2008-01-31 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 31, 2008 at 06:17:20PM -0200, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jan 31, 2008 at 08:57:53PM +0100, Eric Dumazet escreveu: > > Hum... retrans_out should sit close to packets_out (or lost_out/sacked_out > > ???), please. > > > > 'struct tcp_sock' is very large on 64 bits, so I

Re: [PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes on 64-bit arch

2008-01-31 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 31, 2008 at 08:57:53PM +0100, Eric Dumazet escreveu: > Arnaldo Carvalho de Melo a écrit : >> /home/acme/git/net-2.6/net/ipv6/tcp_ipv6.c: >> struct tcp_sock | -16 >> struct tcp6_sock | -16 >> 2 structs changed >> >> Now it is at: >> >> /* size: 1552, cachelines: 25 */ >> /* paddi

Re: [PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes on 64-bit arch

2008-01-31 Thread Eric Dumazet
Arnaldo Carvalho de Melo a écrit : /home/acme/git/net-2.6/net/ipv6/tcp_ipv6.c: struct tcp_sock | -16 struct tcp6_sock | -16 2 structs changed Now it is at: /* size: 1552, cachelines: 25 */ /* paddings: 2, sum paddings: 8 */ /* last cacheline: 16 bytes */ As soon as we stop using skb_qu

[PATCH 6/6] [TCP]: Reorganize struct tcp_sock to save 16 bytes on 64-bit arch

2008-01-31 Thread Arnaldo Carvalho de Melo
/home/acme/git/net-2.6/net/ipv6/tcp_ipv6.c: struct tcp_sock | -16 struct tcp6_sock | -16 2 structs changed Now it is at: /* size: 1552, cachelines: 25 */ /* paddings: 2, sum paddings: 8 */ /* last cacheline: 16 bytes */ As soon as we stop using skb_queue_list we'll get it down to 24 cach