Re: [PATCH 5.10 104/157] mptcp: put subflow sock on connect error

2021-03-24 Thread Sasha Levin
On Wed, Mar 24, 2021 at 10:22:29AM +0100, Greg Kroah-Hartman wrote: On Wed, Mar 24, 2021 at 10:04:12AM +0100, Florian Westphal wrote: Naresh Kamboju wrote: > On Mon, 22 Mar 2021 at 18:15, Greg Kroah-Hartman > wrote: > > > > From: Florian Westphal > > > > [ Upstream commit f07157792c633b528de5

Re: [PATCH 5.10 104/157] mptcp: put subflow sock on connect error

2021-03-24 Thread Greg Kroah-Hartman
On Wed, Mar 24, 2021 at 02:02:06PM +0530, Naresh Kamboju wrote: > On Mon, 22 Mar 2021 at 18:15, Greg Kroah-Hartman > wrote: > > > > From: Florian Westphal > > > > [ Upstream commit f07157792c633b528de5fc1dbe2e4ea54f8e09d4 ] > > > > mptcp_add_pending_subflow() performs a sock_hold() on the subflow

Re: [PATCH 5.10 104/157] mptcp: put subflow sock on connect error

2021-03-24 Thread Greg Kroah-Hartman
On Wed, Mar 24, 2021 at 10:04:12AM +0100, Florian Westphal wrote: > Naresh Kamboju wrote: > > On Mon, 22 Mar 2021 at 18:15, Greg Kroah-Hartman > > wrote: > > > > > > From: Florian Westphal > > > > > > [ Upstream commit f07157792c633b528de5fc1dbe2e4ea54f8e09d4 ] > > > > > > mptcp_add_pending_subf

Re: [PATCH 5.10 104/157] mptcp: put subflow sock on connect error

2021-03-24 Thread Florian Westphal
Naresh Kamboju wrote: > On Mon, 22 Mar 2021 at 18:15, Greg Kroah-Hartman > wrote: > > > > From: Florian Westphal > > > > [ Upstream commit f07157792c633b528de5fc1dbe2e4ea54f8e09d4 ] > > > > mptcp_add_pending_subflow() performs a sock_hold() on the subflow, > > then adds the subflow to the join l

Re: [PATCH 5.10 104/157] mptcp: put subflow sock on connect error

2021-03-24 Thread Naresh Kamboju
On Mon, 22 Mar 2021 at 18:15, Greg Kroah-Hartman wrote: > > From: Florian Westphal > > [ Upstream commit f07157792c633b528de5fc1dbe2e4ea54f8e09d4 ] > > mptcp_add_pending_subflow() performs a sock_hold() on the subflow, > then adds the subflow to the join list. > > Without a sock_put the subflow s