On Thu, Oct 18, 2007 at 08:46:58PM -0700, Roland Dreier wrote:
> > +static void __iomem *mv643xx_eth_base;
>
> > + return readl(((void __iomem *)mv643xx_eth_base) + offset);
>
> Given the declaration of mv643xx_eth_base as void __iomem * already, I
> don't understand why you need the cast to
> +static void __iomem *mv643xx_eth_base;
> +return readl(((void __iomem *)mv643xx_eth_base) + offset);
Given the declaration of mv643xx_eth_base as void __iomem * already, I
don't understand why you need the cast to the same type here (and
elsewhere in the driver).
- R.
-
To unsubscribe
Start counting mv643xx_eth register addresses from zero, instead of
from 0x2000 (MV643XX_ETH_SHARED_REGS.)
Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]>
Acked-by: Tzachi Perelstein <[EMAIL PROTECTED]>
Index: linux-2.6/drivers/net/mv643xx_eth.c
==
