Re: [PATCH 5/7] [XFRM] user: Move attribute copying code into copy_to_user_state_extra

2007-10-09 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 09 Oct 2007 22:36:35 +0800 > [XFRM] user: Move attribute copying code into copy_to_user_state_extra > > Here's a good example of code duplication leading to code rot. The > notification patch did its own netlink message creation for xfrm states. >

[PATCH 5/7] [XFRM] user: Move attribute copying code into copy_to_user_state_extra

2007-10-09 Thread Herbert Xu
[XFRM] user: Move attribute copying code into copy_to_user_state_extra Here's a good example of code duplication leading to code rot. The notification patch did its own netlink message creation for xfrm states. It duplicated code that was already in dump_one_state. Guess what, the next time (and