Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address

2016-02-08 Thread Robert Richter
On 08.02.16 16:30:37, Sergei Shtylyov wrote: > >@@ -897,10 +898,13 @@ static int acpi_get_mac_address(struct acpi_device > >*adev, u8 *dst) > > goto out; > > > > if (!is_valid_ether_addr(mac)) { > >+dev_warn(dev, "MAC address invalid: %pM\n", mac); > >dev_er(), may

Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address

2016-02-08 Thread Sergei Shtylyov
On 02/08/2016 04:49 PM, Bjørn Mork wrote: dev_er(), maybe? I like that! It's often hard to know whether to print something or be quiet. pr_er(), dev_er(), netdev_er() etc would be the perfect solution to that problem. :-D Sorry for the typo... Bjørn MBR, Sergei

Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address

2016-02-08 Thread Bjørn Mork
Sergei Shtylyov writes: >dev_er(), maybe? I like that! It's often hard to know whether to print something or be quiet. pr_er(), dev_er(), netdev_er() etc would be the perfect solution to that problem. Bjørn

Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address

2016-02-08 Thread Sergei Shtylyov
Hello. On 2/8/2016 3:07 PM, sunil.kovv...@gmail.com wrote: From: Robert Richter Signed-off-by: Robert Richter Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/

[PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address

2016-02-08 Thread sunil . kovvuri
From: Robert Richter Signed-off-by: Robert Richter Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cav