Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-31 Thread Nick Kossifidis
2007/8/31, Nick Kossifidis <[EMAIL PROTECTED]>: > 2007/8/30, John W. Linville <[EMAIL PROTECTED]>: > > On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: > > > 2007/8/28, Christoph Hellwig <[EMAIL PROTECTED]>: > > > > > > Also this whole patch seems rather pointless. It saves only >

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-31 Thread Dan Williams
On Fri, 2007-08-31 at 09:30 -0400, Jeff Garzik wrote: > Dan Williams wrote: > > On Thu, 2007-08-30 at 08:36 -0400, John W. Linville wrote: > >> On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: > >>> 2007/8/28, Christoph Hellwig <[EMAIL PROTECTED]>: > Also this whole patch seems

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-31 Thread Jeff Garzik
Dan Williams wrote: On Thu, 2007-08-30 at 08:36 -0400, John W. Linville wrote: On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: 2007/8/28, Christoph Hellwig <[EMAIL PROTECTED]>: Also this whole patch seems rather pointless. It saves only very little and turns the driver into a

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-31 Thread Dan Williams
On Thu, 2007-08-30 at 08:36 -0400, John W. Linville wrote: > On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: > > 2007/8/28, Christoph Hellwig <[EMAIL PROTECTED]>: > > > > Also this whole patch seems rather pointless. It saves only > > > very little and turns the driver into a com

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-30 Thread Nick Kossifidis
2007/8/30, John W. Linville <[EMAIL PROTECTED]>: > On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: > > 2007/8/28, Christoph Hellwig <[EMAIL PROTECTED]>: > > > > Also this whole patch seems rather pointless. It saves only > > > very little and turns the driver into a complete ifdef

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-30 Thread John W. Linville
On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: > 2007/8/28, Christoph Hellwig <[EMAIL PROTECTED]>: > > Also this whole patch seems rather pointless. It saves only > > very little and turns the driver into a complete ifdef maze. > Also most > people will use 5212 code only, 5211

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-30 Thread Christoph Hellwig
On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: > It saves big chunks of code (not only initial register settings > arrays) and we'll extend it's use more inside ath5k_hw.c Trust me this > is a very useful step, eg. check out descriptor processing / setup or > PHY functions (calibr

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-29 Thread Nick Kossifidis
2007/8/28, Christoph Hellwig <[EMAIL PROTECTED]>: > On Tue, Aug 28, 2007 at 12:01:30PM -0400, Jiri Slaby wrote: > > +config ATH5K_AR5210 > > + bool "Support AR5210" > > + depends on ATH5K > > + default y > > + > > +config ATH5K_AR5211 > > + bool "Support AR5211" > > + depends on

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-28 Thread Christoph Hellwig
On Tue, Aug 28, 2007 at 12:01:30PM -0400, Jiri Slaby wrote: > +config ATH5K_AR5210 > + bool "Support AR5210" > + depends on ATH5K > + default y > + > +config ATH5K_AR5211 > + bool "Support AR5211" > + depends on ATH5K > + default y > + > +config ATH5K_AR5212 > + bool "Su

[PATCH 5/5] Net: ath5k, kconfig changes

2007-08-28 Thread Jiri Slaby
ath5k, kconfig changes - build 5120, 5111 and 5112 optionally - alter Kconfig text Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 0902114e92b19bc080780f21f98807688244fc8f tree d7b4a039e4d14ae73faf1b33907c38825d198461 parent 330c2ab9a53ddce27003218bd546034e8eeeff17 author Jiri Slaby <[E