Re: [PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue()

2007-03-21 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2007-03-21 13:21 > Seems like we're lucky, nfnetlink encodes the "subsystem ID" > in the upper 8 bits of the message type and uses 1 as the > smallest ID: Alright, you've been quicker :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue()

2007-03-21 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2007-03-21 13:06 > Thomas Graf wrote: > > * Patrick McHardy <[EMAIL PROTECTED]> 2007-03-21 05:44 > > > >>This looks like it would break nfnetlink, which appears to be > >>using 0 as smallest message type. > > > > > > It shouldn't do that, the first 16 messag

Re: [PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue()

2007-03-21 Thread Patrick McHardy
Patrick McHardy wrote: > Thomas Graf wrote: > >>* Patrick McHardy <[EMAIL PROTECTED]> 2007-03-21 05:44 >> >> >>>This looks like it would break nfnetlink, which appears to be >>>using 0 as smallest message type. >> >> >>It shouldn't do that, the first 16 message types are reserved >>for control mes

Re: [PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue()

2007-03-21 Thread Patrick McHardy
Thomas Graf wrote: > * Patrick McHardy <[EMAIL PROTECTED]> 2007-03-21 05:44 > >>This looks like it would break nfnetlink, which appears to be >>using 0 as smallest message type. > > > It shouldn't do that, the first 16 message types are reserved > for control messages. I'm afraid it does: enu

Re: [PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue()

2007-03-21 Thread Thomas Graf
* Thomas Graf <[EMAIL PROTECTED]> 2007-03-21 12:45 > * Patrick McHardy <[EMAIL PROTECTED]> 2007-03-21 05:44 > > This looks like it would break nfnetlink, which appears to be > > using 0 as smallest message type. > > It shouldn't do that, the first 16 message types are reserved > for control messag

Re: [PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue()

2007-03-21 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2007-03-21 05:44 > This looks like it would break nfnetlink, which appears to be > using 0 as smallest message type. It shouldn't do that, the first 16 message types are reserved for control messages. - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue()

2007-03-20 Thread Patrick McHardy
Thomas Graf wrote: > Changes netlink_rcv_skb() to skip netlink controll messages and don't > pass them on to the message handler. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> > > Index: net-2.6.22/net/netlink/af_netlink.c > ===

[PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue()

2007-03-20 Thread Thomas Graf
Changes netlink_rcv_skb() to skip netlink controll messages and don't pass them on to the message handler. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.22/net/netlink/af_netlink.c === --- net-2.6.22.orig/net/netlink/