Re: [PATCH 4/9 next] fs/io_uring Don't use the return value from import_iovec().

2020-11-06 Thread Pavel Begunkov
On 15/09/2020 15:55, David Laight wrote: > > This is the only code that relies on import_iovec() returning > iter.count on success. > This allows a better interface to import_iovec(). Seems this got nowhere. I'll pick it and send with some other patches to Jens. > Signed-off-by: David Laight >

Re: [PATCH 4/9 next] fs/io_uring Don't use the return value from import_iovec().

2020-09-21 Thread Pavel Begunkov
On 21/09/2020 17:38, David Laight wrote: > From: Christoph Hellwig >> Sent: 21 September 2020 15:15 >> >> On Tue, Sep 15, 2020 at 02:55:20PM +, David Laight wrote: >>> >>> This is the only code that relies on import_iovec() returning >>> iter.count on success. >>> This allows a better interface

RE: [PATCH 4/9 next] fs/io_uring Don't use the return value from import_iovec().

2020-09-21 Thread David Laight
From: Christoph Hellwig > Sent: 21 September 2020 15:15 > > On Tue, Sep 15, 2020 at 02:55:20PM +, David Laight wrote: > > > > This is the only code that relies on import_iovec() returning > > iter.count on success. > > This allows a better interface to import_iovec(). > > This looks generall

Re: [PATCH 4/9 next] fs/io_uring Don't use the return value from import_iovec().

2020-09-21 Thread Christoph Hellwig
On Tue, Sep 15, 2020 at 02:55:20PM +, David Laight wrote: > > This is the only code that relies on import_iovec() returning > iter.count on success. > This allows a better interface to import_iovec(). This looks generall sane, but a comment below: > @@ -3123,7 +3123,7 @@ static int io_read(s

[PATCH 4/9 next] fs/io_uring Don't use the return value from import_iovec().

2020-09-15 Thread David Laight
This is the only code that relies on import_iovec() returning iter.count on success. This allows a better interface to import_iovec(). Signed-off-by: David Laight --- fs/io_uring.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index 3