Re: [PATCH 4/7] Fix qdisc_watchdog_schedule_range_ns range check

2020-10-01 Thread Thomas Gleixner
On Thu, Oct 01 2020 at 22:51, Erez Geva wrote: Fixes should be at the beginning of a patch series and not be hidden somewhere in the middle. >- As all parameters are unsigned. This is not a sentence and this list style does not make that changelog more readable. >- If 'expires' is bigge

[PATCH 4/7] Fix qdisc_watchdog_schedule_range_ns range check

2020-10-01 Thread Erez Geva
- As all parameters are unsigned. - If 'expires' is bigger than 'last_expires' then the left expression overflows. - It is better to use addition and check both ends of the range. Signed-off-by: Erez Geva --- net/sched/sch_api.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletio