Re: [PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

2018-05-26 Thread Sergei Shtylyov
On 05/26/2018 09:46 PM, Sergei Shtylyov wrote: >> The change fixes a sleep in atomic context issue, which can be >> always triggered by running 'ethtool -r' command, because >> phy_start_aneg() protects phydev fields by a mutex. > >Again, I'm unable to reproduce this BUG()... Now I can! I

Re: [PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

2018-05-26 Thread Sergei Shtylyov
On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. Again, I'm unable to reproduce this BUG()... > Another note is t

Re: [PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

2018-05-24 Thread Andrew Lunn
On Thu, May 24, 2018 at 02:11:56PM +0300, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. > > Another note is that the change implicitly repl

[PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
The change fixes a sleep in atomic context issue, which can be always triggered by running 'ethtool -r' command, because phy_start_aneg() protects phydev fields by a mutex. Another note is that the change implicitly replaces phy_start_aneg() with a newer phy_restart_aneg(). Signed-off-by: Vladimi