Re: [PATCH 4/6] mpls: VPLS support

2017-08-21 Thread David Lamparter
On Mon, Aug 21, 2017 at 05:14:46PM +0200, Amine Kherbouche wrote: > > +#include > > some headers are not needed. Which ones? net/ip_tunnels.h is needed for ip_tunnel_get_stats64(). > > +static netdev_tx_t vpls_xmit(struct sk_buff *skb, struct net_device *dev) > > +{ > > + int err = -EINVAL,

Re: [PATCH 4/6] mpls: VPLS support

2017-08-21 Thread Amine Kherbouche
Is it right to put vpls.c file in /net/mpls, I know it's depends essentially from the mpls stack, but vpls is a driver so moving it in /drivers/net should be cleaner but we have to export some mpls functions. Let's see others opinion. On 08/16/2017 07:02 PM, David Lamparter wrote: [work-in-

Re: [PATCH 4/6] mpls: VPLS support

2017-08-21 Thread Amine Kherbouche
new file mode 100644 index ..28ac810da6e9 --- /dev/null +++ b/net/mpls/vpls.c @@ -0,0 +1,469 @@ +/* + * net/mpls/vpls.c + * + * Copyright (C) 2016 David Lamparter + * + */ + +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#inclu

[PATCH 4/6] mpls: VPLS support

2017-08-16 Thread David Lamparter
[work-in-progress, works but needs changes] [v2: refactored lots of things, e.g. dst_metadata, no more genetlink] Signed-off-by: David Lamparter --- include/net/dst_metadata.h | 21 ++ include/net/vpls.h | 8 + net/mpls/Kconfig | 11 ++ net/mpls/Makefile | 1 + n