RE: [PATCH 4/6] ehea: header files

2006-08-15 Thread Michael Ellerman
On Tue, 2006-08-15 at 13:07 +0200, Christoph Raisch wrote: > > "Jenkins, Clive" wrote on 15.08.2006 12:53:05: > > > > > You mean the eHEA has its own concept of page size? Separate from > > the > > > > page size used by the MMU? > > > > > > > > > > yes, the eHEA currently supports only 4K pages f

RE: [PATCH 4/6] ehea: header files

2006-08-15 Thread Christoph Raisch
"Jenkins, Clive" wrote on 15.08.2006 12:53:05: > > > You mean the eHEA has its own concept of page size? Separate from > the > > > page size used by the MMU? > > > > > > > yes, the eHEA currently supports only 4K pages for queues > > In that case, I suggest use the kernel's page size, but add a

RE: [PATCH 4/6] ehea: header files

2006-08-15 Thread Jenkins, Clive
> > You mean the eHEA has its own concept of page size? Separate from the > > page size used by the MMU? > > > > yes, the eHEA currently supports only 4K pages for queues In that case, I suggest use the kernel's page size, but add a compile-time check, and quit with an error message if driver do

Re: [PATCH 4/6] ehea: header files

2006-08-15 Thread Jan-Bernd Themann
Michael Ellerman wrote: On Mon, 2006-08-14 at 14:53 +0200, Jan-Bernd Themann wrote: Michael Ellerman wrote: --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h 1969-12-31 16:00:00.0 -0800 +++ kernel/drivers/net/ehea/ehea.h 2006-08-08 23:59:39.927452928 -0700 + +#define EHEA_PA

Re: [PATCH 4/6] ehea: header files

2006-08-14 Thread Michael Ellerman
On Mon, 2006-08-14 at 14:53 +0200, Jan-Bernd Themann wrote: > Michael Ellerman wrote: > >> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h 1969-12-31 > >> 16:00:00.0 -0800 > >> +++ kernel/drivers/net/ehea/ehea.h 2006-08-08 23:59:39.927452928 -0700 > >> + > >> +#define EHEA_PAGESHIFT 12

Re: [PATCH 4/6] ehea: header files

2006-08-14 Thread Jan-Bernd Themann
Michael Ellerman wrote: --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h 1969-12-31 16:00:00.0 -0800 +++ kernel/drivers/net/ehea/ehea.h 2006-08-08 23:59:39.927452928 -0700 + +#define EHEA_PAGESHIFT 12 +#define EHEA_PAGESIZE 4096UL +#define EHEA_CACHE_LINE 128 This looks

Re: [PATCH 4/6] ehea: header files

2006-08-13 Thread Jan-Bernd Themann
Michael Ellerman wrote: On Sat, 2006-08-12 at 07:40 +1000, Anton Blanchard wrote: Hi, drivers/net/ehea/ehea.h| 452 +#define EHEA_DRIVER_NAME "IBM eHEA" You are using this for ethtool get_drvinfo. Im not sure if it should match the module name, and I worry about having a space in the nam

Re: [PATCH 4/6] ehea: header files

2006-08-13 Thread Michael Ellerman
On Sat, 2006-08-12 at 07:40 +1000, Anton Blanchard wrote: > Hi, > > > drivers/net/ehea/ehea.h| 452 > > > +#define EHEA_DRIVER_NAME "IBM eHEA" > > You are using this for ethtool get_drvinfo. Im not sure if it should > match the module name, and I worry about having a space in the name. A

Re: [PATCH 4/6] ehea: header files

2006-08-12 Thread Thomas Klein
Anton Blanchard wrote: --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h 1969-12-31 +extern void exit(int); Should be able to remove that prototype :) Anton Indeed :-) It's gone. Thomas - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH 4/6] ehea: header files

2006-08-11 Thread Anton Blanchard
> --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h 1969-12-31 > +extern void exit(int); Should be able to remove that prototype :) Anton - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

Re: [PATCH 4/6] ehea: header files

2006-08-11 Thread Anton Blanchard
Hi, > drivers/net/ehea/ehea.h| 452 > +#define EHEA_DRIVER_NAME "IBM eHEA" You are using this for ethtool get_drvinfo. Im not sure if it should match the module name, and I worry about having a space in the name. Any ideas on what we should be doing here? > +#define NET_IP_ALIGN 0 S

Re: [PATCH 4/6] ehea: header files

2006-08-09 Thread Michael Ellerman
Hi Jan-Bernd, I haven't read all of this, but a few things caught my eye ... cheers On Wed, 2006-08-09 at 10:39 +0200, Jan-Bernd Themann wrote: > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> > > > drivers/net/ehea/ehea.h| 452 > + >

Re: [PATCH 4/6] ehea: header files

2006-08-09 Thread Arnd Bergmann
On Wednesday 09 August 2006 10:39, Jan-Bernd Themann wrote: > +extern int ehea_trace_level; > + > +#ifdef EHEA_NO_EDEB > +#define EDEB_P_GENERIC(level, idstring, format, args...) \ > +   while (0 == 1) { \ > +       if(unlikely (level <= ehea_trace_level)) { \ > +   prin

[PATCH 4/6] ehea: header files

2006-08-09 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/ehea/ehea.h| 452 + drivers/net/ehea/ehea_hw.h | 319 +++ 2 files changed, 771 insertions(+) --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h