Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-11 Thread Shuah Khan
On 2/11/21 4:20 AM, Kalle Valo wrote: Shuah Khan writes: On 2/10/21 1:25 AM, Kalle Valo wrote: Shuah Khan writes: ath10k_drain_tx() must not be called with conf_mutex held as workers can use that also. Add check to detect conf_mutex held calls. Signed-off-by: Shuah Khan The commit log

Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-11 Thread Kalle Valo
Shuah Khan writes: > On 2/10/21 1:25 AM, Kalle Valo wrote: >> Shuah Khan writes: >> >>> ath10k_drain_tx() must not be called with conf_mutex held as workers can >>> use that also. Add check to detect conf_mutex held calls. >>> >>> Signed-off-by: Shuah Khan >> >> The commit log does not answer t

Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-10 Thread kernel test robot
Hi Shuah, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on wireless-drivers/master v5.11-rc7 next-20210125] [cannot apply to ath6kl/ath-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And w

Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-10 Thread Shuah Khan
On 2/10/21 1:25 AM, Kalle Valo wrote: Shuah Khan writes: ath10k_drain_tx() must not be called with conf_mutex held as workers can use that also. Add check to detect conf_mutex held calls. Signed-off-by: Shuah Khan The commit log does not answer to "Why?". How did you find this? What actual

Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-10 Thread Kalle Valo
Shuah Khan writes: > ath10k_drain_tx() must not be called with conf_mutex held as workers can > use that also. Add check to detect conf_mutex held calls. > > Signed-off-by: Shuah Khan The commit log does not answer to "Why?". How did you find this? What actual problem are you trying to solve?

Re: [PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-10 Thread kernel test robot
Hi Shuah, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on wireless-drivers/master v5.11-rc7 next-20210125] [cannot apply to ath6kl/ath-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And w

[PATCH 4/5] ath10k: detect conf_mutex held ath10k_drain_tx() calls

2021-02-09 Thread Shuah Khan
ath10k_drain_tx() must not be called with conf_mutex held as workers can use that also. Add check to detect conf_mutex held calls. Signed-off-by: Shuah Khan --- drivers/net/wireless/ath/ath10k/mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/driv