Re: [PATCH 4/4 net-next] net: phy: aquantia: replace magic numbers with constants

On Sun, Feb 03, 2019 at 08:35:54PM +0100, Heiner Kallweit wrote: > Replace magic numbers with proper constants. The original patch is > from Andrew, I extended / adjusted certain parts: > - Use decimal bit numbers. The datasheet uses hex bit numbers 0 .. F. > - Order defines from highest to lowest

[PATCH 4/4 net-next] net: phy: aquantia: replace magic numbers with constants

Replace magic numbers with proper constants. The original patch is from Andrew, I extended / adjusted certain parts: - Use decimal bit numbers. The datasheet uses hex bit numbers 0 .. F. - Order defines from highest to lowest bit numbers - correct some typos - add constant MDIO_AN_TX_VEND_INT_MASK2