Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure

2007-11-30 Thread Serge E. Hallyn
Quoting Eric W. Biederman ([EMAIL PROTECTED]): > "Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > > > > > Hey Eric, > > > > the patches look nice. > > > > The hand-forcing of the passed-in net_ns into a copy of current->nsproxy > > does make it seem like nsproxy may not be the best choice of what t

Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure

2007-11-30 Thread Eric W. Biederman
"Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > > Hey Eric, > > the patches look nice. > > The hand-forcing of the passed-in net_ns into a copy of current->nsproxy > does make it seem like nsproxy may not be the best choice of what to > pass in. Doesn't only net_sysctl_root->lookup() look at the

Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure

2007-11-30 Thread Pavel Emelyanov
[snip] >> +&namespaces, path, table); > > Hey Eric, > > the patches look nice. Agree ;) > The hand-forcing of the passed-in net_ns into a copy of current->nsproxy > does make it seem like nsproxy may not be the best choice of what to > pass in. Doesn't only

Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure

2007-11-30 Thread Serge E. Hallyn
Quoting Eric W. Biederman ([EMAIL PROTECTED]): > > The user interface is: register_net_sysctl_table and > unregister_net_sysctl_table. Very much like the current > interface except there is a network namespace parameter. > > With this any sysctl registered with register_net_sysctl_table > will o

[PATCH 4/4] net: Implement the per network namespace sysctl infrastructure

2007-11-29 Thread Eric W. Biederman
The user interface is: register_net_sysctl_table and unregister_net_sysctl_table. Very much like the current interface except there is a network namespace parameter. With this any sysctl registered with register_net_sysctl_table will only show up to tasks in the same network namespace. All othe