Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-05 Thread Florian Fainelli
On 06/05/2018 02:03 PM, Grygorii Strashko wrote: > > > On 06/02/2018 05:34 AM, Ilias Apalodimas wrote: >> Hi Florian, >> >> Thanks for taking time to look into this >> >> On Fri, Jun 01, 2018 at 02:48:48PM -0700, Florian Fainelli wrote: >>> >>> >>> On 05/24/2018 09:56 PM, Ilias Apalodimas wrote:

Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-05 Thread Grygorii Strashko
On 06/02/2018 05:34 AM, Ilias Apalodimas wrote: > Hi Florian, > > Thanks for taking time to look into this > > On Fri, Jun 01, 2018 at 02:48:48PM -0700, Florian Fainelli wrote: >> >> >> On 05/24/2018 09:56 PM, Ilias Apalodimas wrote: >>> On Thu, May 24, 2018 at 06:39:04PM +0200, Andrew Lunn wr

Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-02 Thread Ilias Apalodimas
On Sat, Jun 02, 2018 at 09:10:08AM -0700, Florian Fainelli wrote: > On June 2, 2018 3:34:32 AM MST, Ilias Apalodimas > wrote: > >Hi Florian, > > > >Thanks for taking time to look into this > > > >On Fri, Jun 01, 2018 at 02:48:48PM -0700, Florian Fainelli wrote: > >> > >> > >> On 05/24/2018 09:

Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-02 Thread Florian Fainelli
On June 2, 2018 3:34:32 AM MST, Ilias Apalodimas wrote: >Hi Florian, > >Thanks for taking time to look into this > >On Fri, Jun 01, 2018 at 02:48:48PM -0700, Florian Fainelli wrote: >> >> >> On 05/24/2018 09:56 PM, Ilias Apalodimas wrote: >> > On Thu, May 24, 2018 at 06:39:04PM +0200, Andrew L

Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-02 Thread Ilias Apalodimas
Hi Florian, Thanks for taking time to look into this On Fri, Jun 01, 2018 at 02:48:48PM -0700, Florian Fainelli wrote: > > > On 05/24/2018 09:56 PM, Ilias Apalodimas wrote: > > On Thu, May 24, 2018 at 06:39:04PM +0200, Andrew Lunn wrote: > >> On Thu, May 24, 2018 at 04:32:34PM +0300, Ilias Apa

Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-01 Thread Florian Fainelli
On 05/24/2018 09:56 PM, Ilias Apalodimas wrote: > On Thu, May 24, 2018 at 06:39:04PM +0200, Andrew Lunn wrote: >> On Thu, May 24, 2018 at 04:32:34PM +0300, Ilias Apalodimas wrote: >>> On Thu, May 24, 2018 at 03:12:29PM +0200, Andrew Lunn wrote: Device tree is supposed to describe the hardwa

Re: [PATCH 4/4] cpsw: add switchdev support

2018-05-24 Thread Ilias Apalodimas
On Thu, May 24, 2018 at 06:39:04PM +0200, Andrew Lunn wrote: > On Thu, May 24, 2018 at 04:32:34PM +0300, Ilias Apalodimas wrote: > > On Thu, May 24, 2018 at 03:12:29PM +0200, Andrew Lunn wrote: > > > Device tree is supposed to describe the hardware. Using that hardware > > > in different ways is no

Re: [PATCH 4/4] cpsw: add switchdev support

2018-05-24 Thread Andrew Lunn
On Thu, May 24, 2018 at 04:32:34PM +0300, Ilias Apalodimas wrote: > On Thu, May 24, 2018 at 03:12:29PM +0200, Andrew Lunn wrote: > > Device tree is supposed to describe the hardware. Using that hardware > > in different ways is not something you should describe in DT. > > > The new switchdev mode

Re: [PATCH 4/4] cpsw: add switchdev support

2018-05-24 Thread Ilias Apalodimas
On Thu, May 24, 2018 at 03:12:29PM +0200, Andrew Lunn wrote: > Device tree is supposed to describe the hardware. Using that hardware > in different ways is not something you should describe in DT. > The new switchdev mode is applied with a .config option in the kernel. What you see is pre-existing

Re: [PATCH 4/4] cpsw: add switchdev support

2018-05-24 Thread Andrew Lunn
> @@ -2626,7 +2750,11 @@ static int cpsw_probe_dt(struct cpsw_platform_data > *data, > data->mac_control = prop; > > if (of_property_read_bool(node, "dual_emac")) > - data->dual_emac = 1; > + data->switch_mode = CPSW_DUAL_EMAC; > + > + /* switchdev overrid

[PATCH 4/4] cpsw: add switchdev support

2018-05-23 Thread Ilias Apalodimas
Signed-off-by: Ilias Apalodimas --- drivers/net/ethernet/ti/cpsw.c | 503 +++- drivers/net/ethernet/ti/cpsw_priv.h | 9 +- 2 files changed, 450 insertions(+), 62 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index