Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-12 Thread Dave Olson
On Thu, 6 Jul 2006, Benjamin Herrenschmidt wrote: | On Thu, 2006-07-06 at 16:34 -0700, Bryan O'Sullivan wrote: | > On Fri, 2006-07-07 at 08:37 +1000, Benjamin Herrenschmidt wrote: | > | > > > +int ipath_unordered_wc(void) | > > > +{ | > > > + return 1; | > > > +} | > > | > > How is the abo

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-06 Thread Benjamin Herrenschmidt
On Thu, 2006-07-06 at 16:34 -0700, Bryan O'Sullivan wrote: > On Fri, 2006-07-07 at 08:37 +1000, Benjamin Herrenschmidt wrote: > > > > +int ipath_unordered_wc(void) > > > +{ > > > + return 1; > > > +} > > > > How is the above providing any kind of serialisation ? > > It's not intended to; it tell

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-06 Thread Bryan O'Sullivan
On Fri, 2006-07-07 at 08:37 +1000, Benjamin Herrenschmidt wrote: > > +int ipath_unordered_wc(void) > > +{ > > + return 1; > > +} > > How is the above providing any kind of serialisation ? It's not intended to; it tells the *caller* whether to do it. http://vger.kernel.org/majordomo-in

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-06 Thread Benjamin Herrenschmidt
> +#if defined(__powerpc__) > + /* There isn't a generic way to specify writethrough mappings */ > + pgprot_val(vma->vm_page_prot) |= _PAGE_NO_CACHE; > + pgprot_val(vma->vm_page_prot) |= _PAGE_WRITETHRU; > + pgprot_val(vma->vm_page_prot) &= ~_PAGE_GUARDED; > +#endif I don't see an

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-03 Thread Michael S. Tsirkin
Quoting r. Anton Blanchard <[EMAIL PROTECTED]>: > Subject: Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath > on PowerPC 970 systems > > > Hi, > > > Please fix the generic code if it doesn't provide the facility > > you need at

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-03 Thread Anton Blanchard
Hi, > Please fix the generic code if it doesn't provide the facility > you need at the moment. Don't shoe horn it into your driver > just to make up for that. Ive had 3 drivers asking for write combining recently so I agree this is a good idea. How about ioremap_wc as suggested by Willy: http

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-06-29 Thread Dave Olson
On Thu, 29 Jun 2006, David Miller wrote: | From: Bryan O'Sullivan <[EMAIL PROTECTED]> | Date: Thu, 29 Jun 2006 14:41:29 -0700 | | > ipath_core-$(CONFIG_X86_64) += ipath_wc_x86_64.o | > +ipath_core-$(CONFIG_PPC64) += ipath_wc_ppc64.o | | Again, don't put these kinds of cpu specific functions | i

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-06-29 Thread David Miller
From: Bryan O'Sullivan <[EMAIL PROTECTED]> Date: Thu, 29 Jun 2006 15:01:39 -0700 > The support for write combining in the kernel is not in a state where > that makes any sense at the moment. Please fix the generic code if it doesn't provide the facility you need at the moment. Don't shoe horn it

[PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-06-29 Thread Bryan O'Sullivan
Ordering of writethrough store buffers needs to be forced, and we need to use ifdef to get writethrough behavior to InfiniPath buffers, because there is no generic way to specify that at this time (similar to code in char/drm/drm_vm.c and block/z2ram.c). Signed-off-by: John Gregor <[EMAIL PROTECTE

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-06-29 Thread David Miller
From: Bryan O'Sullivan <[EMAIL PROTECTED]> Date: Thu, 29 Jun 2006 14:41:29 -0700 > ipath_core-$(CONFIG_X86_64) += ipath_wc_x86_64.o > +ipath_core-$(CONFIG_PPC64) += ipath_wc_ppc64.o Again, don't put these kinds of cpu specific functions into the infiniband driver. They are potentially globally

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-06-29 Thread Bryan O'Sullivan
On Thu, 2006-06-29 at 14:53 -0700, David Miller wrote: > From: Bryan O'Sullivan <[EMAIL PROTECTED]> > Date: Thu, 29 Jun 2006 14:41:29 -0700 > > > ipath_core-$(CONFIG_X86_64) += ipath_wc_x86_64.o > > +ipath_core-$(CONFIG_PPC64) += ipath_wc_ppc64.o > > Again, don't put these kinds of cpu specific