Re: [PATCH 3/9 v1 RFC] skbuff: replace sock_zerocopy_put() with skb_zcopy_put()

2020-12-21 Thread Willem de Bruijn
> > > All uargs should have a callback function, (unless nouarg > > > is set), so push all special case logic handling down into > > > the callbacks. This slightly pessimizes the refcounted cases, > > > > What does this mean? > > The current zerocopy_put() code does: > 1) if uarg, dec refcount,

Re: [PATCH 3/9 v1 RFC] skbuff: replace sock_zerocopy_put() with skb_zcopy_put()

2020-12-21 Thread Jonathan Lemon
On Sat, Dec 19, 2020 at 01:46:13PM -0500, Willem de Bruijn wrote: > On Fri, Dec 18, 2020 at 3:20 PM Jonathan Lemon > wrote: > > > > From: Jonathan Lemon > > > > In preparation for further work, the zcopy* routines will > > become basic building blocks, while the zerocopy* ones will > > be specif

Re: [PATCH 3/9 v1 RFC] skbuff: replace sock_zerocopy_put() with skb_zcopy_put()

2020-12-19 Thread Willem de Bruijn
On Fri, Dec 18, 2020 at 3:20 PM Jonathan Lemon wrote: > > From: Jonathan Lemon > > In preparation for further work, the zcopy* routines will > become basic building blocks, while the zerocopy* ones will > be specific for the existing zerocopy implementation. Plural. There already are multiple di

[PATCH 3/9 v1 RFC] skbuff: replace sock_zerocopy_put() with skb_zcopy_put()

2020-12-18 Thread Jonathan Lemon
From: Jonathan Lemon In preparation for further work, the zcopy* routines will become basic building blocks, while the zerocopy* ones will be specific for the existing zerocopy implementation. All uargs should have a callback function, (unless nouarg is set), so push all special case logic handl