Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP

2018-11-30 Thread Willem de Bruijn
On Fri, Nov 30, 2018 at 5:16 PM Deepa Dinamani wrote: > > On Sun, Nov 25, 2018 at 10:19 AM David Miller wrote: > > > > From: Willem de Bruijn > > Date: Sun, 25 Nov 2018 09:18:55 -0500 > > > > > The existing logic is as is for a reason. There is no need to change > > > it to satisfy the main purp

Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP

2018-11-30 Thread Deepa Dinamani
On Sun, Nov 25, 2018 at 10:19 AM David Miller wrote: > > From: Willem de Bruijn > Date: Sun, 25 Nov 2018 09:18:55 -0500 > > > The existing logic is as is for a reason. There is no need to change > > it to satisfy the main purpose of your patchset? > > > > It is structured as one bit to test wheth

Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP

2018-11-25 Thread David Miller
From: Willem de Bruijn Date: Sun, 25 Nov 2018 09:18:55 -0500 > The existing logic is as is for a reason. There is no need to change > it to satisfy the main purpose of your patchset? > > It is structured as one bit to test whether a timestamp is requested > and another to select among two varian

Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP

2018-11-25 Thread Willem de Bruijn
On Sun, Nov 25, 2018 at 12:06 AM Deepa Dinamani wrote: > > On Sat, Nov 24, 2018 at 7:59 PM Willem de Bruijn > wrote: > > > > On Sat, Nov 24, 2018 at 3:59 AM Deepa Dinamani > > wrote: > > > > > > SOCK_RCVTSTAMPNS is never set alone. SOCK_RCVTSTAMP > > > is always set along with SOCK_RCVTSTAMPNS.

Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP

2018-11-24 Thread Deepa Dinamani
On Sat, Nov 24, 2018 at 7:59 PM Willem de Bruijn wrote: > > On Sat, Nov 24, 2018 at 3:59 AM Deepa Dinamani wrote: > > > > SOCK_RCVTSTAMPNS is never set alone. SOCK_RCVTSTAMP > > is always set along with SOCK_RCVTSTAMPNS. This leads to > > checking for two flag states whenever we need to check for

Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP

2018-11-24 Thread Willem de Bruijn
On Sat, Nov 24, 2018 at 3:59 AM Deepa Dinamani wrote: > > SOCK_RCVTSTAMPNS is never set alone. SOCK_RCVTSTAMP > is always set along with SOCK_RCVTSTAMPNS. This leads to > checking for two flag states whenever we need to check for > SOCK_RCVTSTAMPS. > > Also SOCK_RCVTSTAMPS was the only flag that n

[PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP

2018-11-23 Thread Deepa Dinamani
SOCK_RCVTSTAMPNS is never set alone. SOCK_RCVTSTAMP is always set along with SOCK_RCVTSTAMPNS. This leads to checking for two flag states whenever we need to check for SOCK_RCVTSTAMPS. Also SOCK_RCVTSTAMPS was the only flag that needed to be checked in order to verify if either of the two flags ar