Re: [PATCH 3/7] tcp: rearrange microsecond rtt sampling used by vegas

2005-11-11 Thread David S. Miller
From: Ingo Oeser <[EMAIL PROTECTED]> Date: Fri, 11 Nov 2005 16:33:07 +0100 > Are you sure, that you don't mean just "rtt_sample(sk, tcp_usrtt(skb));" here? > I always believed that function pointers used like I proposed above. Both methods of invoking a function via function pointer work the same

Re: [PATCH 3/7] tcp: rearrange microsecond rtt sampling used by vegas

2005-11-11 Thread Ingo Oeser
Hi Stephen, Stephen Hemminger wrote: > + if (rtt_sample) > + (*rtt_sample)(sk, tcp_usrtt(skb)); > } Are you sure, that you don't mean just "rtt_sample(sk, tcp_usrtt(skb));" here? I always believed that function

[PATCH 3/7] tcp: rearrange microsecond rtt sampling used by vegas

2005-11-09 Thread Stephen Hemminger
Simplify the code that comuputes microsecond rtt estimate used by TCP Vegas. Move the callback out of the RTT sampler and into the end of the ack cleanup. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/net/ipv4/tcp_input.c +++ net-2.6/net/ipv4/tcp_input.c @@ -548,10 +548,9