Re: [PATCH 3/7] [IPSEC]: Move common output code to xfrm_output

2007-10-08 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 9 Oct 2007 09:02:57 +0800 > On Mon, Oct 08, 2007 at 05:17:17PM -0700, David Miller wrote: > > > > Could you submit a 2.6.23 version of just the ipv4 fix? > > It might be interesting to determine why it was omitted, > > perhaps it was an oversight, a

Re: [PATCH 3/7] [IPSEC]: Move common output code to xfrm_output

2007-10-08 Thread Herbert Xu
On Mon, Oct 08, 2007 at 05:17:17PM -0700, David Miller wrote: > > Could you submit a 2.6.23 version of just the ipv4 fix? > It might be interesting to determine why it was omitted, > perhaps it was an oversight, and it probably predates the > addition of skb_reset_*(). OK I double-checked and it

Re: [PATCH 3/7] [IPSEC]: Move common output code to xfrm_output

2007-10-08 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 08 Oct 2007 19:29:39 +0800 > [IPSEC]: Move common output code to xfrm_output > > Most of the code in xfrm4_output_one and xfrm6_output_one are identical so > this patch moves them into a common xfrm_output function which will live > in net/xfrm. >

[PATCH 3/7] [IPSEC]: Move common output code to xfrm_output

2007-10-08 Thread Herbert Xu
[IPSEC]: Move common output code to xfrm_output Most of the code in xfrm4_output_one and xfrm6_output_one are identical so this patch moves them into a common xfrm_output function which will live in net/xfrm. In fact this would seem to fix a bug as on IPv4 we never reset the network header after