Re: [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core

2007-04-30 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Mon, 23 Apr 2007 17:01:03 +0100 > [L2TP]: Add PPP-over-L2TP driver core. > > This driver handles only L2TP data frames; control frames are handled > by a userspace application. It implements L2TP using the PPPoX socket > family. Data is sent or receiv

Re: [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core

2007-04-26 Thread James Chapman
Patrick McHardy wrote: James Chapman wrote: Patrick McHardy wrote: Still the ugly old_data_ready/old_sk_destruct and pppol2tp_fget hacks. I added comments in the code about why I think pppol2tp_fget is needed. This driver handles PPP-over-L2TP sockets. These are attached to a plain UDP (L2TP

Re: [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core

2007-04-26 Thread Patrick McHardy
James Chapman wrote: > Patrick McHardy wrote: > >> Still the ugly old_data_ready/old_sk_destruct and pppol2tp_fget hacks. > > > I added comments in the code about why I think pppol2tp_fget is needed. > This driver handles PPP-over-L2TP sockets. These are attached to a plain > UDP (L2TP) socket.

Re: [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core

2007-04-24 Thread James Chapman
Patrick McHardy wrote: James Chapman wrote: +static void pppol2tp_recv_dequeue(struct pppol2tp_session *session) +{ + struct sk_buff *skb; + struct sk_buff *tmp; + + /* If the pkt at the head of the queue has the nr that we +* expect to send up next, dequeue it and any

Re: [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core

2007-04-24 Thread Patrick McHardy
James Chapman wrote: > +static void pppol2tp_recv_dequeue(struct pppol2tp_session *session) > +{ > + struct sk_buff *skb; > + struct sk_buff *tmp; > + > + /* If the pkt at the head of the queue has the nr that we > + * expect to send up next, dequeue it and any other > + * in-