Re: [PATCH 3/4] net: ethernet: ti: cpsw: don't duplicate ndev_running

2017-01-17 Thread Ivan Khoronzhuk
On Thu, Jan 12, 2017 at 11:34:47AM -0600, Grygorii Strashko wrote: Hi Grygorii, Sorry for late reply. > > > On 01/10/2017 07:56 PM, Ivan Khoronzhuk wrote: > > On Mon, Jan 09, 2017 at 11:25:38AM -0600, Grygorii Strashko wrote: > >> > >> > >> On 01/08/2017 10:41 AM, Ivan Khoronzhuk wrote: > >>> N

Re: [PATCH 3/4] net: ethernet: ti: cpsw: don't duplicate ndev_running

2017-01-12 Thread Grygorii Strashko
On 01/10/2017 07:56 PM, Ivan Khoronzhuk wrote: > On Mon, Jan 09, 2017 at 11:25:38AM -0600, Grygorii Strashko wrote: >> >> >> On 01/08/2017 10:41 AM, Ivan Khoronzhuk wrote: >>> No need to create additional vars to identify if interface is running. >>> So simplify code by removing redundant var and

Re: [PATCH 3/4] net: ethernet: ti: cpsw: don't duplicate ndev_running

2017-01-10 Thread Ivan Khoronzhuk
On Mon, Jan 09, 2017 at 11:25:38AM -0600, Grygorii Strashko wrote: > > > On 01/08/2017 10:41 AM, Ivan Khoronzhuk wrote: > > No need to create additional vars to identify if interface is running. > > So simplify code by removing redundant var and checking usage counter > > instead. > > > > Signed

Re: [PATCH 3/4] net: ethernet: ti: cpsw: don't duplicate ndev_running

2017-01-09 Thread Grygorii Strashko
On 01/08/2017 10:41 AM, Ivan Khoronzhuk wrote: > No need to create additional vars to identify if interface is running. > So simplify code by removing redundant var and checking usage counter > instead. > > Signed-off-by: Ivan Khoronzhuk > --- > drivers/net/ethernet/ti/cpsw.c | 14

[PATCH 3/4] net: ethernet: ti: cpsw: don't duplicate ndev_running

2017-01-08 Thread Ivan Khoronzhuk
No need to create additional vars to identify if interface is running. So simplify code by removing redundant var and checking usage counter instead. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --gi